Re: [PATCH] V3: Idle in transaction cancellation

From: Andres Freund <andres(at)anarazel(dot)de>
To: "Kevin Grittner" <Kevin(dot)Grittner(at)wicourts(dot)gov>
Cc: pgsql-hackers(at)postgresql(dot)org
Subject: Re: [PATCH] V3: Idle in transaction cancellation
Date: 2010-11-02 21:36:19
Message-ID: 201011022236.19913.andres@anarazel.de
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Tuesday 02 November 2010 18:33:15 Kevin Grittner wrote:
> Andres Freund <andres(at)anarazel(dot)de> wrote:
> > * You wont see an error if the next command after the IDLE in
> > transaction is a COMMIT/ROLLBACK. I don*t see any sensible way
> > around that.
> Well, on a ROLLBACK I'm not sure it's a problem. On a COMMIT,
> couldn't you call a function to check for it in CommitTransaction
> and PrepareTransaction?
Sure, throwing an error somewhere wouldnt be that hard. But at the moment a
COMMIT is always successfull (and just reporting a ROLLBACK in a failed txn).
Doesn't seem to be something to changed lightly.

Does anybody have any idea why COMMIT is allowed there? Seems pretty strange
to me.

Andres

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2010-11-02 21:47:39 Re: Hash support for arrays
Previous Message Robert Haas 2010-11-02 21:28:01 Re: Hash support for arrays