Skip site navigation (1) Skip section navigation (2)

pgAdmin III commit: Fix two deletes of the same object in a query tool

From: Guillaume Lelarge <guillaume(at)lelarge(dot)info>
To: pgadmin-hackers(at)postgresql(dot)org
Subject: pgAdmin III commit: Fix two deletes of the same object in a query tool
Date: 2010-10-14 10:01:15
Message-ID: 201010141001.o9EA1FXa013935@gothos.postgresql.org (view raw or flat)
Thread:
Lists: pgadmin-hackers
Fix two deletes of the same object in a query tool

When a user executes a query and wants to save the results, he clicks on the
disk-with-a-green-arrow icon. If he clicks on the Cancel button, pgAdmin
crashes. The issue was that we deleted two times the qi->toFileExportForm
object. Once in the frmQuery code and once in the qi destroy method. Fixed by
deleting the one in the frmQuery code.

Report from Jean-Michel Souchard.

Fixes #255.

Branch
------
REL-1_12_0_PATCHES

Details
-------
http://git.postgresql.org/gitweb?p=pgadmin3.git;a=commitdiff;h=69017b51753035ac3bd50af2db3a41a288e5695b

Modified Files
--------------
pgadmin/frm/frmQuery.cpp |    1 -
1 files changed, 0 insertions(+), 1 deletions(-)

pgadmin-hackers by date

Next:From: pgAdmin TracDate: 2010-10-14 10:02:39
Subject: Re: [pgAdmin III] #255: Crash of the query tool if one cancels the export dialog
Previous:From: pgAdmin TracDate: 2010-10-14 09:57:50
Subject: [pgAdmin III] #255: Crash of the query tool if one cancels the export dialog

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group