Skip site navigation (1) Skip section navigation (2)

pgAdmin III commit: Fix CREATE INDEX/CONSTRAINT syntax

From: Guillaume Lelarge <guillaume(at)lelarge(dot)info>
To: pgadmin-hackers(at)postgresql(dot)org
Subject: pgAdmin III commit: Fix CREATE INDEX/CONSTRAINT syntax
Date: 2010-10-06 19:14:38
Message-ID: 201010061914.o96JEc89084146@gothos.postgresql.org (view raw or flat)
Thread:
Lists: pgadmin-hackers
Fix CREATE INDEX/CONSTRAINT syntax

Reverse the order of TABLESPACE and WITH() clauses for indexes.  Previously
pgAdminIII generated CREATE scripts like:

CREATE INDEX foo_foo_id ON foo USING btree (foo_id)
  TABLESPACE bar WITH (FILLFACTOR=50);

However this is illegal PostgreSQL syntax, the WITH() clause must come before
TABLESPACE.

The statement generated by "new index" dialog is already correct.

Branch
------
REL-1_12_0_PATCHES

Details
-------
http://git.postgresql.org/gitweb?p=pgadmin3.git;a=commitdiff;h=c102486cfdc5976e786526583f45208f20ec5cbb

Modified Files
--------------
pgadmin/schema/pgIndex.cpp |    6 +++---
1 files changed, 3 insertions(+), 3 deletions(-)

pgadmin-hackers by date

Next:From: Guillaume LelargeDate: 2010-10-06 19:18:39
Subject: Re: [PATCH] Fix CREATE INDEX/CONSTRAINT syntax when tablespace and fillfactor are specified
Previous:From: Guillaume LelargeDate: 2010-10-06 18:10:49
Subject: pgAdmin website commit: Update .pot file.

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group