Skip site navigation (1) Skip section navigation (2)

Commitfest: The Good, The Bad, and the Ugly

From: David Fetter <david(at)fetter(dot)org>
To: PostgreSQL General <pgsql-general(at)postgresql(dot)org>,PG Hackers <pgsql-hackers(at)postgresql(dot)org>,Round Robin Reviewers <pgsql-rrreviewers(at)postgresql(dot)org>
Subject: Commitfest: The Good, The Bad, and the Ugly
Date: 2010-09-28 21:03:15
Message-ID: 20100928210315.GA23393@fetter.org (view raw or flat)
Thread:
Lists: pgsql-generalpgsql-hackerspgsql-rrreviewers
Folks,

We're almost half way through the commitfest, and so I'll start with:

The Good:

- Most patches still in play have a reviewer.

- It's possible for one person to post 5 reviews in a day.  Robert
  Haas actually did this on his own time yesterday.

- New people have been reviewing patches, at least up to the
  Submission criteria.

The Bad:

- There is 1 (one) patch marked "Committed" or "Ready for Committer,"
  where neither the author nor reviewer is a committer.  This
  basically means we have approximately one RRReviewer.

The Ugly:

- Patches are not getting even basic QA.

The Bad and the Ugly are fixable, and here's how.

At the moment, we've got 7 basic review criteria
http://wiki.postgresql.org/wiki/Reviewing_a_Patch, 5 of which can be
accomplished with C skills somewhere between 0 and tiny.  These are:

  1. Submission review (skills needed: patch, English comprehension)
  2. Usability review (skills needed: test-fu, ability to find and read spec)
  3. Feature test (skills needed: patch, configure, make, pipe errors to log)
  4. Performance review (skills needed: ability to time performance)
  5. Coding review (skills needed: guideline comparison, experience with portability issues, minor C-reading skills)

I'd like to set as a goal that every patch in this commitfest get
those levels of review.  You do not need C skills[1].  You do not need
to be a genius database engine hacker[2].  You just need to be
diligent and want to move the project ahead.

If you haven't yet, get signed in and start reviewing patches.  Sign
in with your community login, and let's get going :)
https://commitfest.postgresql.org/action/commitfest_view?id=7

In case you were wondering, what I'm doing here is part of step 7.

If you think that getting all outstanding patches through step 5 is
not doable, let me know.  If you think it is, this is your chance to
help make it happen.  Write back either way.

Cheers,
David.

[1] If you do have them, help out with step 6, too.
[2] If you are one, help out with step 6, too.
-- 
David Fetter <david(at)fetter(dot)org> http://fetter.org/
Phone: +1 415 235 3778  AIM: dfetter666  Yahoo!: dfetter
Skype: davidfetter      XMPP: david(dot)fetter(at)gmail(dot)com
iCal: webcal://www.tripit.com/feed/ical/people/david74/tripit.ics

Remember to vote!
Consider donating to Postgres: http://www.postgresql.org/about/donate

Responses

pgsql-hackers by date

Next:From: Tom LaneDate: 2010-09-28 21:03:27
Subject: Re: Proposal: plpgsql - "for in array" statement
Previous:From: Robert HaasDate: 2010-09-28 20:49:29
Subject: Re: Proposal: plpgsql - "for in array" statement

pgsql-rrreviewers by date

Next:From: Itagaki TakahiroDate: 2010-09-29 01:11:00
Subject: Re: [HACKERS] Commitfest: The Good, The Bad, and the Ugly
Previous:From: Pavel StehuleDate: 2010-09-26 10:39:21
Subject: Re: wip: functions median and percentile

pgsql-general by date

Next:From: Ivan Sergio BorgonovoDate: 2010-09-28 21:48:16
Subject: Re: huge difference in performance between MS SQL and pg 8.3 on UPDATE with full text search
Previous:From: Bruce MomjianDate: 2010-09-28 20:38:57
Subject: Re: pg_upgrade

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group