Skip site navigation (1) Skip section navigation (2)

Re: pgsql: Fix another join removal bug: the check on PlaceHolderVars was w

From: David Fetter <david(at)fetter(dot)org>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: pgsql-committers(at)postgresql(dot)org
Subject: Re: pgsql: Fix another join removal bug: the check on PlaceHolderVars was w
Date: 2010-09-26 00:29:16
Message-ID: 20100926002916.GA22240@fetter.org (view raw or flat)
Thread:
Lists: pgsql-committers
On Sat, Sep 25, 2010 at 11:04:28PM +0000, Tom Lane wrote:
> Fix another join removal bug: the check on PlaceHolderVars was
> wrong.
> 
> The previous coding would decide that join removal was unsafe upon
> finding a PlaceHolderVar that needed to be evaluated at the inner
> rel and then used above the join.  However, this fails to cover the
> case of PlaceHolderVars that refer to both the inner rel and some
> other rels.  Per bug report from Andrus.

The person who found it originally was Kirill (xitology) Simonov.  He
brought it up in IRC. :)

Cheers,
David.
-- 
David Fetter <david(at)fetter(dot)org> http://fetter.org/
Phone: +1 415 235 3778  AIM: dfetter666  Yahoo!: dfetter
Skype: davidfetter      XMPP: david(dot)fetter(at)gmail(dot)com
iCal: webcal://www.tripit.com/feed/ical/people/david74/tripit.ics

Remember to vote!
Consider donating to Postgres: http://www.postgresql.org/about/donate

In response to

Responses

pgsql-committers by date

Next:From: Tom LaneDate: 2010-09-26 00:51:04
Subject: pgsql: Minor improvements to git_changelog.
Previous:From: Tom LaneDate: 2010-09-25 23:33:44
Subject: pgsql: Rename git_topo_order -> git_changelog, per discussion.

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group