Skip site navigation (1) Skip section navigation (2)

pgAdmin III commit: Fix connection color on the query tool

From: Guillaume Lelarge <guillaume(at)lelarge(dot)info>
To: pgadmin-hackers(at)postgresql(dot)org
Subject: pgAdmin III commit: Fix connection color on the query tool
Date: 2010-09-25 07:03:59
Message-ID: 201009250703.o8P73x06086122@gothos.postgresql.org (view raw or flat)
Thread:
Lists: pgadmin-hackers
Fix connection color on the query tool

The color used the old connection informations. In fact, we call two times the
OnChangeConnection() method. First time to choose another connection and add
the new one to the combobox, and another time to really change the connection.
IOW, we change the colors despite the fact we actually didn't change the
connection. So we can't check the connection with the connection global
variable. We need to give the connection local variable to the
GetServerColour() method. So, this method gets a connection parameter.

Report from Valentine Gogichashvili.

Fixed #241.

Branch
------
master

Details
-------
http://git.postgresql.org/gitweb?p=pgadmin3.git;a=commitdiff;h=ca2c30b6e5cb8a608c3462443cedc21ca6790f9e

Modified Files
--------------
pgadmin/frm/frmQuery.cpp       |   10 +++++-----
pgadmin/include/frm/frmQuery.h |    2 +-
2 files changed, 6 insertions(+), 6 deletions(-)

pgadmin-hackers by date

Next:From: pgAdmin TracDate: 2010-09-25 07:05:54
Subject: Re: [pgAdmin III] #241: Connection color is not correctly changed in query windows connection drop-down
Previous:From: pgAdmin TracDate: 2010-09-25 06:51:01
Subject: [pgAdmin III] #241: Connection color is not correctly changed in query windows connection drop-down

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group