Skip site navigation (1) Skip section navigation (2)

pgsql: Fix join-removal logic for pseudoconstant and outerjoin-delayed

From: tgl(at)postgresql(dot)org (Tom Lane)
To: pgsql-committers(at)postgresql(dot)org
Subject: pgsql: Fix join-removal logic for pseudoconstant and outerjoin-delayed
Date: 2010-09-14 23:15:30
Message-ID: 20100914231530.0FA047541E2@cvs.postgresql.org (view raw or flat)
Thread:
Lists: pgsql-committers
Log Message:
-----------
Fix join-removal logic for pseudoconstant and outerjoin-delayed quals.

In these cases a qual can get marked with the removable rel in its
required_relids, but this is just to schedule its evaluation correctly, not
because it really depends on the rel.  We were assuming that, in effect,
we could throw away *all* quals so marked, which is nonsense.  Tighten up
the logic to be a little more paranoid about which quals belong to the
outer join being considered for removal, and arrange for all quals that
don't belong to be updated so they will still get evaluated correctly.

Also fix another problem that happened to be exposed by this test case,
which was that make_join_rel() was failing to notice some cases where
a constant-false qual could be used to prove a join relation empty.  If it's
a pushed-down constant false, then the relation is empty even if it's an
outer join, because the qual applies after the outer join expansion.

Per report from Nathan Grange.  Back-patch into 9.0.

Modified Files:
--------------
    pgsql/src/backend/optimizer/path:
        joinrels.c (r1.105 -> r1.106)
        (http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/backend/optimizer/path/joinrels.c?r1=1.105&r2=1.106)
    pgsql/src/backend/optimizer/plan:
        analyzejoins.c (r1.3 -> r1.4)
        (http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/backend/optimizer/plan/analyzejoins.c?r1=1.3&r2=1.4)
    pgsql/src/backend/optimizer/util:
        joininfo.c (r1.52 -> r1.53)
        (http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/backend/optimizer/util/joininfo.c?r1=1.52&r2=1.53)
    pgsql/src/include/optimizer:
        joininfo.h (r1.38 -> r1.39)
        (http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/include/optimizer/joininfo.h?r1=1.38&r2=1.39)
    pgsql/src/test/regress/expected:
        join.out (r1.46 -> r1.47)
        (http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/test/regress/expected/join.out?r1=1.46&r2=1.47)
    pgsql/src/test/regress/sql:
        join.sql (r1.35 -> r1.36)
        (http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/test/regress/sql/join.sql?r1=1.35&r2=1.36)

pgsql-committers by date

Next:From: Tom LaneDate: 2010-09-14 23:15:37
Subject: pgsql: Fix join-removal logic for pseudoconstant and outerjoin-delayed
Previous:From: Heikki LinnakangasDate: 2010-09-14 13:35:14
Subject: pgsql: Oops, the timeout argument to WaitLatchOrSocket is in

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group