Skip site navigation (1) Skip section navigation (2)

Re: Fix for pg_upgrade's forcing pg_controldata into English

From: Bruce Momjian <bruce(at)momjian(dot)us>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Alvaro Herrera <alvherre(at)commandprompt(dot)com>, Greg Sabino Mullane <greg(at)turnstep(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Fix for pg_upgrade's forcing pg_controldata into English
Date: 2010-09-01 23:56:45
Message-ID: 201009012356.o81Nuj405114@momjian.us (view raw or flat)
Thread:
Lists: pgsql-hackers
Tom Lane wrote:
> Bruce Momjian <bruce(at)momjian(dot)us> writes:
> > Tom Lane wrote:
> >> However, that's something for 9.1 and beyond.  Bruce's immediate problem
> >> is what to do in pg_upgrade in 9.0, and there I concur that he should
> >> duplicate what pg_regress is doing.
> 
> > OK, here is a patch that sets all the variables that pg_regress.c sets.
> 
> I certainly hope that pg_regress isn't freeing the strings it passes
> to putenv() ...

pg_regress does not restore these settings (it says with C/English) so
the code is different.

-- 
  Bruce Momjian  <bruce(at)momjian(dot)us>        http://momjian.us
  EnterpriseDB                             http://enterprisedb.com

  + It's impossible for everything to be true. +

In response to

Responses

pgsql-hackers by date

Next:From: Tom LaneDate: 2010-09-02 00:08:47
Subject: Re: Fix for pg_upgrade's forcing pg_controldata into English
Previous:From: Tom LaneDate: 2010-09-01 23:55:45
Subject: Re: compiling with RELCACHE_FORCE_RELEASE doesn't pass regression

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group