| From: | tgl(at)postgresql(dot)org (Tom Lane) |
|---|---|
| To: | pgsql-committers(at)postgresql(dot)org |
| Subject: | pgsql: Fix ExecMakeTableFunctionResult to verify that all rows returned |
| Date: | 2010-08-26 18:54:38 |
| Message-ID: | 20100826185438.175517541D7@cvs.postgresql.org |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers |
Log Message:
-----------
Fix ExecMakeTableFunctionResult to verify that all rows returned by a SRF
returning "record" actually do have the same rowtype. This is needed because
the parser can't realistically enforce that they will all have the same typmod,
as seen in a recent example from David Wheeler.
Back-patch to 8.0, which is as far back as we have the notion of RECORD
subtypes being distinguished by typmod. Wheeler's example depends on
8.4-and-up features, but I suspect there may be ways to provoke similar
failures before 8.4.
Modified Files:
--------------
pgsql/src/backend/executor:
execQual.c (r1.264 -> r1.265)
(http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/backend/executor/execQual.c?r1=1.264&r2=1.265)
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2010-08-26 18:54:44 | pgsql: Fix ExecMakeTableFunctionResult to verify that all rows returned |
| Previous Message | Tom Lane | 2010-08-26 18:34:44 | pgsql: Don't auto-create the subdirectories holding built documentation |