pgsql: Improve hint message for ENOMEM failure from shmget().

From: tgl(at)postgresql(dot)org (Tom Lane)
To: pgsql-committers(at)postgresql(dot)org
Subject: pgsql: Improve hint message for ENOMEM failure from shmget().
Date: 2010-08-25 20:11:00
Message-ID: 20100825201100.0972E7541D7@cvs.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Log Message:
-----------
Improve hint message for ENOMEM failure from shmget().

It turns out that some platforms return ENOMEM for a request that violates
SHMALL, whereas we were assuming that ENOSPC would always be used for that.
Apparently the latter is a Linuxism while ENOMEM is the BSD tradition.
Extend the ENOMEM hint to suggest that raising SHMALL might be needed.
Per gripe from A.M.

Backpatch to 9.0, but not further, because this doesn't seem important
enough to warrant creating extra translation work in the stable branches.
(If it were, we'd have figured this out years ago.)

Tags:
----
REL9_0_STABLE

Modified Files:
--------------
pgsql/src/backend/port:
sysv_shmem.c (r1.57 -> r1.57.2.1)
(http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/backend/port/sysv_shmem.c?r1=1.57&r2=1.57.2.1)

Browse pgsql-committers by date

  From Date Subject
Next Message Tom Lane 2010-08-25 21:42:56 pgsql: Document filtering dictionaries in textsearch.sgml.
Previous Message Tom Lane 2010-08-25 20:10:55 pgsql: Improve hint message for ENOMEM failure from shmget().