Skip site navigation (1) Skip section navigation (2)

pgAdmin III commit: Make the dlgSelectConnection combobox read/write

From: Guillaume Lelarge <guillaume(at)lelarge(dot)info>
To: pgadmin-hackers(at)postgresql(dot)org
Subject: pgAdmin III commit: Make the dlgSelectConnection combobox read/write
Date: 2010-08-23 08:35:41
Message-ID: 201008230835.o7N8Zfau008211@gothos.postgresql.org (view raw or flat)
Thread:
Lists: pgadmin-hackers
Commit: http://git.postgresql.org/gitweb?p=pgadmin3.git;a=commitdiff;h=ab76ad229f54cd89b407f32fc0c1edcf04a68aa9

Log Message
-----------
Make the dlgSelectConnection combobox read/write

When a user launches the dlgSelectConnection dialog from the query tool, all
combobox are read-only, forcing the user to select one of the available items
on each combobox.

When a user launches pgAdmin with -q or -S command line options, he first gets
the dlgSelectConnection dialog. As no connection is already made, the only
thing the combox box will have depends on the previous quick connect action.
So, the combobox should be read/write, so that he can change the values.

It used to work in 1.10, but was broken since 1.12 because of one of my
patches.

Reported by Steffen Kuhn. Patch by him, reworked by me.

Branch
------
REL-1_12_0_PATCHES

Modified Files
--------------
pgadmin/dlg/dlgSelectConnection.cpp       |   14 +++++++++-----
pgadmin/include/dlg/dlgSelectConnection.h |    2 +-
pgadmin/ui/dlgSelectConnection.xrc        |    4 ----
3 files changed, 10 insertions(+), 10 deletions(-)

pgadmin-hackers by date

Next:From: Guillaume LelargeDate: 2010-08-23 08:39:25
Subject: Re: ReadOnly ComboBoxes in dlgSelectConnection.cpp
Previous:From: Guillaume LelargeDate: 2010-08-23 07:14:54
Subject: Re: Updated Czech translation

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group