Skip site navigation (1) Skip section navigation (2)

pgsql: Use a non-locale-dependent definition of isspace() in

From: tgl(at)postgresql(dot)org (Tom Lane)
To: pgsql-committers(at)postgresql(dot)org
Subject: pgsql: Use a non-locale-dependent definition of isspace() in
Date: 2010-08-21 16:55:52
Message-ID: 20100821165552.271EF7541D7@cvs.postgresql.org (view raw or flat)
Thread:
Lists: pgsql-committers
Log Message:
-----------
Use a non-locale-dependent definition of isspace() in array_in/array_out.

array_in discards unquoted leading and trailing whitespace in array values,
while array_out is careful to quote array elements that contain whitespace.
This is problematic when the definition of "whitespace" varies between
locales: array_in could drop characters that were meant to be part of the
value.  To avoid that, lock down "whitespace" to mean only the traditional
six ASCII space characters.

This change also works around a bug in OS X and some older BSD systems, in
which isspace() could return true for character fragments in UTF8 locales.
(There may be other places in PG where that bug could cause problems, but
this is the only one complained of so far; see recent report from Steven
Schlansker.)

Back-patch to 9.0, but not further.  Given the lack of previous reports
of trouble, changing this behavior in stable branches seems to offer
more risk of breaking applications than reward of avoiding problems.

Modified Files:
--------------
    pgsql/src/backend/utils/adt:
        arrayfuncs.c (r1.165 -> r1.166)
        (http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/backend/utils/adt/arrayfuncs.c?r1=1.165&r2=1.166)

pgsql-committers by date

Next:From: Tom LaneDate: 2010-08-21 16:55:58
Subject: pgsql: Use a non-locale-dependent definition of isspace() in
Previous:From: Tom LaneDate: 2010-08-21 13:59:58
Subject: pgsql: Improve parallel restore's ability to cope with selective restore

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group