Skip site navigation (1) Skip section navigation (2)

pgsql: Keep exec_simple_check_plan() from thinking "SELECT foo INTO bar"

From: tgl(at)postgresql(dot)org (Tom Lane)
To: pgsql-committers(at)postgresql(dot)org
Subject: pgsql: Keep exec_simple_check_plan() from thinking "SELECT foo INTO bar"
Date: 2010-08-19 18:11:08
Message-ID: 20100819181108.7B9D87541D7@cvs.postgresql.org (view raw or flat)
Thread:
Lists: pgsql-committers
Log Message:
-----------
Keep exec_simple_check_plan() from thinking "SELECT foo INTO bar" is simple.

It's not clear if this situation can occur in plpgsql other than via the
EXECUTE USING case Heikki illustrated, which I will shortly close off.
However, ignoring the intoClause if it's there is surely wrong, so let's
patch it for safety.

Backpatch to 8.3, which is as far back as this code has a PlannedStmt
to deal with.  There might be another way to make an equivalent test
before that, but since this is just preventing hypothetical bugs,
I'm not going to obsess about it.

Tags:
----
REL8_3_STABLE

Modified Files:
--------------
    pgsql/src/pl/plpgsql/src:
        pl_exec.c (r1.202.2.9 -> r1.202.2.10)
        (http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/pl/plpgsql/src/pl_exec.c?r1=1.202.2.9&r2=1.202.2.10)

pgsql-committers by date

Next:From: Tom LaneDate: 2010-08-19 18:57:57
Subject: pgsql: Allow USING and INTO clauses of plpgsql's EXECUTE to appear in
Previous:From: Tom LaneDate: 2010-08-19 18:11:02
Subject: pgsql: Keep exec_simple_check_plan() from thinking "SELECT foo INTO bar"

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group