pgsql: Fix another longstanding problem in copy_relation_data: it was

From: tgl(at)postgresql(dot)org (Tom Lane)
To: pgsql-committers(at)postgresql(dot)org
Subject: pgsql: Fix another longstanding problem in copy_relation_data: it was
Date: 2010-07-29 19:23:37
Message-ID: 20100729192337.F37C97541D5@cvs.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Log Message:
-----------
Fix another longstanding problem in copy_relation_data: it was blithely
assuming that a local char[] array would be aligned on at least a word
boundary. There are architectures on which that is pretty much guaranteed to
NOT be the case ... and those arches also don't like non-aligned memory
accesses, meaning that log_newpage() would crash if it ever got invoked.
Even on Intel-ish machines there's a potential for a large performance penalty
from doing I/O to an inadequately aligned buffer. So palloc it instead.

Backpatch to 8.0 --- 7.4 doesn't have this code.

Tags:
----
REL8_4_STABLE

Modified Files:
--------------
pgsql/src/backend/commands:
tablecmds.c (r1.288.2.4 -> r1.288.2.5)
(http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/backend/commands/tablecmds.c?r1=1.288.2.4&r2=1.288.2.5)

Browse pgsql-committers by date

  From Date Subject
Next Message Tom Lane 2010-07-29 19:23:44 pgsql: Fix another longstanding problem in copy_relation_data: it was
Previous Message Tom Lane 2010-07-29 19:23:28 pgsql: Fix another longstanding problem in copy_relation_data: it was