Skip site navigation (1) Skip section navigation (2)

Re: Re: [COMMITTERS] pgsql: Fix log_temp_files docs and comments to say bytes not kilobytes.

From: Bruce Momjian <bruce(at)momjian(dot)us>
To: Robert Haas <robertmhaas(at)gmail(dot)com>
Cc: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Josh Berkus <josh(at)agliodbs(dot)com>, pgsql-hackers(at)postgresql(dot)org
Subject: Re: Re: [COMMITTERS] pgsql: Fix log_temp_files docs and comments to say bytes not kilobytes.
Date: 2010-07-06 15:03:45
Message-ID: 201007061503.o66F3je12085@momjian.us (view raw or flat)
Thread:
Lists: pgsql-committerspgsql-hackers
Robert Haas wrote:
> I think my least favorite option is changing the behavior only in
> HEAD.  I think the reasonable options are:
> 
> 1. Change the behavior in HEAD, 8.4, and 8.3, per previous discussion.
>  If we do this, we should do what I proposed in my previous email.
> 
> 2. Change the comments and documentation in 8.4 and 8.3 along the
> lines that Simon already did in HEAD.  If we do this, we also need to
> change the GUC units to something other than GUC_UNIT_KB, as noted
> upthread.  I'm not sure what would be appropriate.
> 
> The reason I think it's OK to change the behavior in the back-branches
> is that (a) the only thing it affects is logging, so it shouldn't
> really "break" anything, and (b) apparently nobody has noticed that
> the interpretation of the GUC is off by three orders of magnitude, so
> either nobody's using it or they're not looking at what's actually
> happening too carefully.  But I'm OK with going the other way and
> changing the code and docs in the back-branches, too.  I just think we
> should be consistent.

I normally don't backpatch anything unless it is either a possible cause
of data loss, or a problem that is reported by multiple people. 

Anything backpatched risks causing instability, and might discourage
people from performing minor upgrades.  Minor fixes are rarely worth the
risk of causing instability in back-branches.

-- 
  Bruce Momjian  <bruce(at)momjian(dot)us>        http://momjian.us
  EnterpriseDB                             http://enterprisedb.com

  + None of us is going to be here forever. +

In response to

Responses

pgsql-hackers by date

Next:From: Robert HaasDate: 2010-07-06 15:05:06
Subject: Re: Re: [COMMITTERS] pgsql: Fix log_temp_files docs and comments to say bytes not kilobytes.
Previous:From: Robert HaasDate: 2010-07-06 15:03:24
Subject: Re: 64-bit pgbench V2

pgsql-committers by date

Next:From: Robert HaasDate: 2010-07-06 15:05:06
Subject: Re: Re: [COMMITTERS] pgsql: Fix log_temp_files docs and comments to say bytes not kilobytes.
Previous:From: Robert HaasDate: 2010-07-06 14:52:48
Subject: Re: Re: [COMMITTERS] pgsql: Fix log_temp_files docs and comments to say bytes not kilobytes.

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group