Skip site navigation (1) Skip section navigation (2)

Re: 9.0beta2 - server crash when using HS + SR

From: Bruce Momjian <bruce(at)momjian(dot)us>
To: Bruce Momjian <bruce(at)momjian(dot)us>
Cc: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Fujii Masao <masao(dot)fujii(at)gmail(dot)com>, Greg Smith <greg(at)2ndquadrant(dot)com>, Rafael Martinez <r(dot)m(dot)guerrero(at)usit(dot)uio(dot)no>, Robert Haas <robertmhaas(at)gmail(dot)com>, pgsql-hackers(at)postgresql(dot)org
Subject: Re: 9.0beta2 - server crash when using HS + SR
Date: 2010-07-02 02:44:48
Message-ID: 201007020244.o622imV20225@momjian.us (view raw or flat)
Thread:
Lists: pgsql-hackers
Bruce Momjian wrote:
> Tom Lane wrote:
> > Bruce Momjian <bruce(at)momjian(dot)us> writes:
> > > The attached patch shows the hint only during recovery.
> > 
> > BTW, it would be easier and more consistent with the rest of the code to
> > look at InRecovery, instead of messing around with the function
> > signature.  And the usual way to emit a hint conditionally is
> > 
> > 	(InRecovery ? errhint(...) : 0)
> > 
> > rather than duplicate a lot of surrounding code.
> 
> Thanks for the "hints".   I was thinking there was a way to use ? : for
> the hint, but couldn't find an example.  I see examples now.  Updated
> patch attached.

Applied.

-- 
  Bruce Momjian  <bruce(at)momjian(dot)us>        http://momjian.us
  EnterpriseDB                             http://enterprisedb.com

  + None of us is going to be here forever. +

In response to

pgsql-hackers by date

Next:From: Bruce MomjianDate: 2010-07-02 03:00:00
Subject: Re: No hash join across partitioned tables?
Previous:From: Bruce MomjianDate: 2010-07-02 01:31:32
Subject: Re: bitmap indexes - performance

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group