| From: | Bruce Momjian <bruce(at)momjian(dot)us> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | Fujii Masao <masao(dot)fujii(at)gmail(dot)com>, Greg Smith <greg(at)2ndquadrant(dot)com>, Rafael Martinez <r(dot)m(dot)guerrero(at)usit(dot)uio(dot)no>, Robert Haas <robertmhaas(at)gmail(dot)com>, pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: 9.0beta2 - server crash when using HS + SR |
| Date: | 2010-06-30 23:41:53 |
| Message-ID: | 201006302341.o5UNfrp07888@momjian.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Tom Lane wrote:
> Bruce Momjian <bruce(at)momjian(dot)us> writes:
> > The attached patch shows the hint only during recovery.
>
> BTW, it would be easier and more consistent with the rest of the code to
> look at InRecovery, instead of messing around with the function
> signature. And the usual way to emit a hint conditionally is
>
> (InRecovery ? errhint(...) : 0)
>
> rather than duplicate a lot of surrounding code.
Thanks for the "hints". I was thinking there was a way to use ? : for
the hint, but couldn't find an example. I see examples now. Updated
patch attached.
--
Bruce Momjian <bruce(at)momjian(dot)us> http://momjian.us
EnterpriseDB http://enterprisedb.com
+ None of us is going to be here forever. +
| Attachment | Content-Type | Size |
|---|---|---|
| /pgpatches/tablespace | text/x-diff | 980 bytes |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2010-06-30 23:41:56 | Re: Check constraints on non-immutable keys |
| Previous Message | Tom Lane | 2010-06-30 23:40:39 | Re: Keeping separate WAL segments for each database |