Skip site navigation (1) Skip section navigation (2)

pgsql: Rearrange dblink's dblink_build_sql_insert() and related routines

From: tgl(at)postgresql(dot)org (Tom Lane)
To: pgsql-committers(at)postgresql(dot)org
Subject: pgsql: Rearrange dblink's dblink_build_sql_insert() and related routines
Date: 2010-06-14 20:49:58
Message-ID: 20100614204958.037CE7541D4@cvs.postgresql.org (view raw or flat)
Thread:
Lists: pgsql-committers
Log Message:
-----------
Rearrange dblink's dblink_build_sql_insert() and related routines to open and
lock the target relation just once per SQL function call.  The original coding
obtained and released lock several times per call.  Aside from saving a
not-insignificant number of cycles, this eliminates possible race conditions
if someone tries to modify the relation's schema concurrently.  Also
centralize locking and permission-checking logic.

Problem noted while investigating a trouble report from Robert Voinea --- his
problem is still to be fixed, though.

Tags:
----
REL8_1_STABLE

Modified Files:
--------------
    pgsql/contrib/dblink:
        dblink.c (r1.48.2.8 -> r1.48.2.9)
        (http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/contrib/dblink/dblink.c?r1=1.48.2.8&r2=1.48.2.9)

pgsql-committers by date

Next:From: Tom LaneDate: 2010-06-14 20:50:04
Subject: pgsql: Rearrange dblink's dblink_build_sql_insert() and related routines
Previous:From: Tom LaneDate: 2010-06-14 20:49:52
Subject: pgsql: Rearrange dblink's dblink_build_sql_insert() and related routines

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group