Re: BUG #5488: pg_dump does not quote column names -> pg_restore may fail when upgrading

David Fetter wrote:
> On Fri, Jun 04, 2010 at 02:59:48PM -0400, Bruce Momjian wrote:
> > Kevin Grittner wrote:
> > > Hartmut Goebel <h(dot)goebel(at)goebel-consult(dot)de> wrote:
> > >
> > > > The application already quotes all column names :-) It's using a
> > > > generic framework which does not (and must not) rely on column
> > > > names being non-keywords.
> > >
> > > Same here. I suspect that this is much more commonn than many
> > > PostgreSQL developers realize; and I think it makes a reasonable
> > > case for at least an *option* to quote all identifiers emitted by
> > > pg_dump.
> >
> > Even if we quote them in the dump, I assume applications would need
> > to quote them too, which I doubt many do.
>
> It seems like something that's doable by pg_dump as a "default off"
> option. TODO for 9.1?

This is the bug report that prompted this thread:

http://archives.postgresql.org/pgsql-bugs/2010-06/msg00018.php

I bigger question is why wouldn't we backpatch WINDOW as quoted in
pg_dump when we release back-branches? That would make the bug go away,
rather than require users to use a special flag (and find out only after
they were doing the reload).

--
Bruce Momjian <bruce(at)momjian(dot)us> http://momjian.us
EnterpriseDB http://enterprisedb.com

+ None of us is going to be here forever. +