pgsql: Rewrite LIKE's %-followed-by-_ optimization so it really works

From: tgl(at)postgresql(dot)org (Tom Lane)
To: pgsql-committers(at)postgresql(dot)org
Subject: pgsql: Rewrite LIKE's %-followed-by-_ optimization so it really works
Date: 2010-05-28 17:35:24
Message-ID: 20100528173524.05FBB7541D2@cvs.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Log Message:
-----------
Rewrite LIKE's %-followed-by-_ optimization so it really works (this time
for sure ;-)). It now also optimizes more cases, such as %_%_. Improve
comments too. Per bug #5478.

In passing, also rename the TCHAR macro to GETCHAR, because pgindent is
messing with the formatting of the former (apparently it now thinks TCHAR
is a typedef name).

Back-patch to 8.3, where the bug was introduced.

Modified Files:
--------------
pgsql/src/backend/utils/adt:
like_match.c (r1.27 -> r1.28)
(http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/backend/utils/adt/like_match.c?r1=1.27&r2=1.28)
pgsql/src/test/regress/expected:
strings.out (r1.40 -> r1.41)
(http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/test/regress/expected/strings.out?r1=1.40&r2=1.41)
pgsql/src/test/regress/sql:
strings.sql (r1.28 -> r1.29)
(http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/test/regress/sql/strings.sql?r1=1.28&r2=1.29)

Browse pgsql-committers by date

  From Date Subject
Next Message Tom Lane 2010-05-28 17:35:30 pgsql: Rewrite LIKE's %-followed-by-_ optimization so it really works
Previous Message Takahiro Itagaki 2010-05-28 16:34:16 pgsql: PGDLLEXPORT is __declspec (dllexport) only on MSVC, but is