pgsql: Fix oversight in construction of sort/unique plans for

From: tgl(at)postgresql(dot)org (Tom Lane)
To: pgsql-committers(at)postgresql(dot)org
Subject: pgsql: Fix oversight in construction of sort/unique plans for
Date: 2010-05-25 17:44:47
Message-ID: 20100525174447.C0B007541D2@cvs.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Log Message:
-----------
Fix oversight in construction of sort/unique plans for UniquePaths.
If the original IN operator is cross-type, for example int8 = int4,
we need to use int4 < int4 to sort the inner data and int4 = int4
to unique-ify it. We got the first part of that right, but tried to
use the original IN operator for the equality checks. Per bug #5472
from Vlad Romascanu.

Backpatch to 8.4, where the bug was introduced by the patch that unified
SortClause and GroupClause. I was able to take out a whole lot of on-the-fly
calls of get_equality_op_for_ordering_op(), but failed to realize that
I needed to put one back in right here :-(

Tags:
----
REL8_4_STABLE

Modified Files:
--------------
pgsql/src/backend/optimizer/plan:
createplan.c (r1.260.2.1 -> r1.260.2.2)
(http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/backend/optimizer/plan/createplan.c?r1=1.260.2.1&r2=1.260.2.2)

Browse pgsql-committers by date

  From Date Subject
Next Message Tom Lane 2010-05-25 18:12:11 Re: pgsql: Remove IMPLEMENTATION.jp file from pg_upgrade docs; still in
Previous Message Tom Lane 2010-05-25 17:44:42 pgsql: Fix oversight in construction of sort/unique plans for