Skip site navigation (1) Skip section navigation (2)

pgsql: Fix oversight in construction of sort/unique plans for

From: tgl(at)postgresql(dot)org (Tom Lane)
To: pgsql-committers(at)postgresql(dot)org
Subject: pgsql: Fix oversight in construction of sort/unique plans for
Date: 2010-05-25 17:44:42
Message-ID: 20100525174442.0D1C67541D2@cvs.postgresql.org (view raw or flat)
Thread:
Lists: pgsql-committers
Log Message:
-----------
Fix oversight in construction of sort/unique plans for UniquePaths.
If the original IN operator is cross-type, for example int8 = int4,
we need to use int4 < int4 to sort the inner data and int4 = int4
to unique-ify it.  We got the first part of that right, but tried to
use the original IN operator for the equality checks.  Per bug #5472
from Vlad Romascanu.

Backpatch to 8.4, where the bug was introduced by the patch that unified
SortClause and GroupClause.  I was able to take out a whole lot of on-the-fly
calls of get_equality_op_for_ordering_op(), but failed to realize that
I needed to put one back in right here :-(

Modified Files:
--------------
    pgsql/src/backend/optimizer/plan:
        createplan.c (r1.274 -> r1.275)
        (http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/backend/optimizer/plan/createplan.c?r1=1.274&r2=1.275)

pgsql-committers by date

Next:From: Tom LaneDate: 2010-05-25 17:44:47
Subject: pgsql: Fix oversight in construction of sort/unique plans for
Previous:From: Michael MeskesDate: 2010-05-25 17:28:56
Subject: Re: pgsql: Added a configure test for "long long" datatypes.

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group