Hiroshi Inoue wrote:
> Bruce Momjian wrote:
> > Takahiro Itagaki wrote:
> >> Takahiro Itagaki <itagaki(dot)takahiro(at)oss(dot)ntt(dot)co(dot)jp> wrote:
> >>> Revised patch attached. Please test it.
> >> I applied this version of the patch.
> >> Please check wheter the bug is fixed and any buildfarm failures.
> > Great. I have merged in my C comments into the code with the attached
> > patch so we remember why the code is setup as it is.
> > One thing I am confused about is that, for Win32, our numeric/monetary
> > handling sets lc_ctype to match numeric/monetary, while our time code in
> > the same file uses that method _and_ uses wcsftime() to return the value
> > in wide characters. So, why do we do both for time? Is there any value
> > to that?
> Unfortunately wcsftime() is a halfway conveniece function which uses
> ANSI version of functionalities internally.
> AFAIC the only way to remove the dependency to LC_CTYPE is to call
> GeLocaleInfoW() directly.
Thanks. I have documented this fact in a C comment; patch attached.
Bruce Momjian <bruce(at)momjian(dot)us> http://momjian.us
Description: text/x-diff (1.2 KB)
In response to
pgsql-hackers by date
|Next:||From: Thom Brown||Date: 2010-04-26 13:40:56|
|Subject: Re: CIText and pattern_ops|
|Previous:||From: Robert Haas||Date: 2010-04-26 13:19:58|
|Subject: Re: Re: [COMMITTERS] pgsql: Make CheckRequiredParameterValues() depend upon correct|
pgsql-general by date
|Next:||From: Bruce Momjian||Date: 2010-04-26 14:01:44|
|Subject: Re: Inheritance efficiency|
|Previous:||From: Eustace Scrubb||Date: 2010-04-26 11:45:18|
|Subject: Start-up script for few clusters: just add water?|