Skip site navigation (1) Skip section navigation (2)

Re: [GENERAL] trouble with to_char('L')

From: Bruce Momjian <bruce(at)momjian(dot)us>
To: Takahiro Itagaki <itagaki(dot)takahiro(at)oss(dot)ntt(dot)co(dot)jp>
Cc: Hiroshi Inoue <inoue(at)tpf(dot)co(dot)jp>, Magnus Hagander <magnus(at)hagander(dot)net>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: [GENERAL] trouble with to_char('L')
Date: 2010-04-24 23:03:28
Message-ID: 201004242303.o3ON3Sk05147@momjian.us (view raw or flat)
Thread:
Lists: pgsql-generalpgsql-hackers
Takahiro Itagaki wrote:
> 
> Takahiro Itagaki <itagaki(dot)takahiro(at)oss(dot)ntt(dot)co(dot)jp> wrote:
> 
> > Revised patch attached. Please test it.
> 
> I applied this version of the patch.
> Please check wheter the bug is fixed and any buildfarm failures.

Great.  I have merged in my C comments into the code with the attached
patch so we remember why the code is setup as it is.

One thing I am confused about is that, for Win32, our numeric/monetary
handling sets lc_ctype to match numeric/monetary, while our time code in
the same file uses that method _and_ uses wcsftime() to return the value
in wide characters.  So, why do we do both for time?  Is there any value
to that?

Seems we should do the same for both numeric/monetary and time.

-- 
  Bruce Momjian  <bruce(at)momjian(dot)us>        http://momjian.us
  EnterpriseDB                             http://enterprisedb.com

Attachment: /rtmp/diff
Description: text/x-diff (7.6 KB)

In response to

Responses

pgsql-hackers by date

Next:From: Bruce MomjianDate: 2010-04-25 00:07:06
Subject: Re: [RFC] nodeToString format and exporting the SQL parser
Previous:From: Robert HaasDate: 2010-04-24 23:01:05
Subject: Re: global temporary tables

pgsql-general by date

Next:From: Fredric FredricsonDate: 2010-04-24 23:09:23
Subject: Re: How to allow PostgreSQL to accept remote connection?
Previous:From: Thom BrownDate: 2010-04-24 22:53:07
Subject: Re: Help me stop postgres from crashing.

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group