From:
Bruce Momjian <bruce(at)momjian(dot)us>
To:
Takahiro Itagaki <itagaki(dot)takahiro(at)oss(dot)ntt(dot)co(dot)jp>
Cc:
Hiroshi Inoue <inoue(at)tpf(dot)co(dot)jp>, Magnus Hagander <magnus(at)hagander(dot)net>,
PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject:
Re: [GENERAL] trouble with to_char('L')
Date:
2010-04-24 23:03:28
Message-ID:
201004242303.o3ON3Sk05147@momjian.us (view raw or flat )
Thread:
2009-04-20 21:00:07 from Mikko <mhannesy(at)gmail(dot)com>
2009-04-21 10:36:44 from "Albe Laurenz" <laurenz(dot)albe(at)wien(dot)gv(dot)at>
2009-04-21 13:58:21 from Mikko <mhannesy(at)gmail(dot)com>
2009-04-21 17:13:38 from Alvaro Herrera <alvherre(at)commandprompt(dot)com>
2009-04-21 20:32:18 from Mikko <mhannesy(at)gmail(dot)com>
2009-04-21 23:13:22 from Alvaro Herrera <alvherre(at)commandprompt(dot)com>
2009-04-22 17:06:24 from Mikko <mhannesy(at)gmail(dot)com>
2009-04-22 17:58:48 from Alvaro Herrera <alvherre(at)commandprompt(dot)com>
2009-04-22 18:35:22 from Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
2009-04-22 21:35:28 from Hiroshi Inoue <inoue(at)tpf(dot)co(dot)jp>
2009-05-29 18:16:26 from Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
2009-06-02 03:22:13 from Hiroshi Inoue <inoue(at)tpf(dot)co(dot)jp>
2009-06-03 18:06:00 from Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
2009-06-03 23:41:41 from Hiroshi Inoue <inoue(at)tpf(dot)co(dot)jp>
2010-02-25 23:21:58 from Bruce Momjian <bruce(at)momjian(dot)us>
2010-02-25 23:32:05 from Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
2010-02-25 23:33:29 from Bruce Momjian <bruce(at)momjian(dot)us>
2010-02-25 23:46:53 from Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
2010-02-26 00:16:15 from Bruce Momjian <bruce(at)momjian(dot)us>
2010-02-26 00:44:37 from Hiroshi Inoue <inoue(at)tpf(dot)co(dot)jp>
2010-02-26 00:52:48 from Bruce Momjian <bruce(at)momjian(dot)us>
2010-02-26 23:06:31 from Hiroshi Inoue <inoue(at)tpf(dot)co(dot)jp>
2010-02-27 21:42:34 from Bruce Momjian <bruce(at)momjian(dot)us>
2010-02-28 04:28:12 from Bruce Momjian <bruce(at)momjian(dot)us>
2010-02-28 15:13:56 from Bruce Momjian <bruce(at)momjian(dot)us>
2010-03-01 11:00:15 from Hiroshi Inoue <inoue(at)tpf(dot)co(dot)jp>
2010-03-02 03:36:44 from Bruce Momjian <bruce(at)momjian(dot)us>
2010-03-02 14:40:46 from Hiroshi Inoue <inoue(at)tpf(dot)co(dot)jp>
2010-03-02 18:14:00 from Bruce Momjian <bruce(at)momjian(dot)us>
2010-03-12 06:52:07 from Takahiro Itagaki <itagaki(dot)takahiro(at)oss(dot)ntt(dot)co(dot)jp>
2010-03-12 17:13:48 from Bruce Momjian <bruce(at)momjian(dot)us>
2010-03-18 03:34:20 from Takahiro Itagaki <itagaki(dot)takahiro(at)oss(dot)ntt(dot)co(dot)jp>
2010-03-22 20:14:53 from Bruce Momjian <bruce(at)momjian(dot)us>
2010-04-16 10:52:27 from Magnus Hagander <magnus(at)hagander(dot)net>
2010-04-19 01:59:42 from Takahiro Itagaki <itagaki(dot)takahiro(at)oss(dot)ntt(dot)co(dot)jp>
2010-04-19 12:02:32 from Magnus Hagander <magnus(at)hagander(dot)net>
2010-04-20 08:34:09 from Takahiro Itagaki <itagaki(dot)takahiro(at)oss(dot)ntt(dot)co(dot)jp>
2010-04-20 13:23:45 from Bruce Momjian <bruce(at)momjian(dot)us>
2010-04-20 14:28:23 from Hiroshi Inoue <inoue(at)tpf(dot)co(dot)jp>
2010-04-21 01:50:26 from Takahiro Itagaki <itagaki(dot)takahiro(at)oss(dot)ntt(dot)co(dot)jp>
2010-04-22 02:00:50 from Takahiro Itagaki <itagaki(dot)takahiro(at)oss(dot)ntt(dot)co(dot)jp>
2010-04-24 23:03:28 from Bruce Momjian <bruce(at)momjian(dot)us>
2010-04-26 00:19:49 from Hiroshi Inoue <inoue(at)tpf(dot)co(dot)jp>
2010-04-26 13:32:11 from Bruce Momjian <bruce(at)momjian(dot)us>
2010-04-20 13:38:24 from Bruce Momjian <bruce(at)momjian(dot)us>
2010-04-20 13:10:18 from Bruce Momjian <bruce(at)momjian(dot)us>
Lists:
pgsql-general pgsql-hackers
Takahiro Itagaki wrote:
>
> Takahiro Itagaki <itagaki(dot)takahiro(at)oss(dot)ntt(dot)co(dot)jp> wrote:
>
> > Revised patch attached. Please test it.
>
> I applied this version of the patch.
> Please check wheter the bug is fixed and any buildfarm failures.
Great. I have merged in my C comments into the code with the attached
patch so we remember why the code is setup as it is.
One thing I am confused about is that, for Win32, our numeric/monetary
handling sets lc_ctype to match numeric/monetary, while our time code in
the same file uses that method _and_ uses wcsftime() to return the value
in wide characters. So, why do we do both for time? Is there any value
to that?
Seems we should do the same for both numeric/monetary and time.
--
Bruce Momjian <bruce(at)momjian(dot)us> http://momjian.us
EnterpriseDB http://enterprisedb.com
Attachment: /rtmp/diff
Description: text/x-diff (7.6 KB)
In response to
Responses
pgsql-hackers by date
Next :From: Bruce MomjianDate: 2010-04-25 00:07:06Subject : Re: [RFC] nodeToString format and exporting the SQL
parserPrevious :From : Robert HaasDate : 2010-04-24 23:01:05Subject : Re: global temporary tables
pgsql-general by date
Next :From: Fredric FredricsonDate: 2010-04-24 23:09:23Subject : Re: How to allow PostgreSQL to accept remote connection?Previous :From : Thom BrownDate : 2010-04-24 22:53:07Subject : Re: Help me stop postgres from crashing.
