From: | Bruce Momjian <bruce(at)momjian(dot)us> |
---|---|
To: | Takahiro Itagaki <itagaki(dot)takahiro(at)oss(dot)ntt(dot)co(dot)jp> |
Cc: | Magnus Hagander <magnus(at)hagander(dot)net>, Hiroshi Inoue <inoue(at)tpf(dot)co(dot)jp>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: [GENERAL] trouble with to_char('L') |
Date: | 2010-04-20 13:23:45 |
Message-ID: | 201004201323.o3KDNjv28954@momjian.us |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-general pgsql-hackers |
Takahiro Itagaki wrote:
>
> Magnus Hagander <magnus(at)hagander(dot)net> wrote:
>
> > > 1. setlocale(LC_CTYPE, lc_monetary)
> > > 2. setlocale(LC_MONETARY, lc_monetary)
> > > 3. lc = localeconv()
> > > 4. pg_do_encoding_conversion(lc->xxx,
> > > FROM pg_get_encoding_from_locale(lc_monetary),
> > > TO GetDatabaseEncoding())
> > > 5. Revert LC_CTYPE and LC_MONETARY.
>
> A patch attached for the above straightforwardly. Does this work?
> Note that #ifdef WIN32 parts in the patch are harmless on other platforms
> even if they are enabled.
I like this patch. Instead of having special code to convert from the
_current_ locale, you pass the encoding name to our routines. This does
mean we are bound by supporting only the encodings PG supports, not the
full range of Win32 encodings, but that seems fine.
--
Bruce Momjian <bruce(at)momjian(dot)us> http://momjian.us
EnterpriseDB http://enterprisedb.com
From | Date | Subject | |
---|---|---|---|
Next Message | Tom Lane | 2010-04-20 13:36:22 | Re: Int64GetDatum |
Previous Message | Bruce Momjian | 2010-04-20 13:10:18 | Re: [GENERAL] trouble with to_char('L') |
From | Date | Subject | |
---|---|---|---|
Next Message | Kevin Grittner | 2010-04-20 13:35:06 | Re: [DOCS] Streaming replication document improvements |
Previous Message | Bruce Momjian | 2010-04-20 13:10:18 | Re: [GENERAL] trouble with to_char('L') |