pgsql: Move the responsibility for calling StartupXLOG into

From: tgl(at)postgresql(dot)org (Tom Lane)
To: pgsql-committers(at)postgresql(dot)org
Subject: pgsql: Move the responsibility for calling StartupXLOG into
Date: 2010-04-20 01:38:52
Message-ID: 20100420013852.C40FC7541D0@cvs.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Log Message:
-----------
Move the responsibility for calling StartupXLOG into InitPostgres, for
those process types that go through InitPostgres; in particular, bootstrap
and standalone-backend cases. This ensures that we have set up a PGPROC
and done some other basic initialization steps (corresponding to the
if (IsUnderPostmaster) block in AuxiliaryProcessMain) before we attempt to
run WAL recovery in a standalone backend. As was discovered last September,
this is necessary for some corner-case code paths during WAL recovery,
particularly end-of-WAL cleanup.

Moving the bootstrap case here too is not necessary for correctness, but it
seems like a good idea since it reduces the number of distinct code paths.

Modified Files:
--------------
pgsql/src/backend/bootstrap:
bootstrap.c (r1.260 -> r1.261)
(http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/backend/bootstrap/bootstrap.c?r1=1.260&r2=1.261)
pgsql/src/backend/tcop:
postgres.c (r1.592 -> r1.593)
(http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/backend/tcop/postgres.c?r1=1.592&r2=1.593)
pgsql/src/backend/utils/init:
postinit.c (r1.208 -> r1.209)
(http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/backend/utils/init/postinit.c?r1=1.208&r2=1.209)

Browse pgsql-committers by date

  From Date Subject
Next Message Robert Haas 2010-04-20 11:15:07 pgsql: Rename standby_keep_segments to wal_keep_segments.
Previous Message Robert Haas 2010-04-20 00:29:35 Re: pgsql: Update docs as to when WAL logging can be skipped.