Re: pgindent excluded files list

From: Bruce Momjian <bruce(at)momjian(dot)us>
To: Andrew Dunstan <andrew(at)dunslane(dot)net>
Cc: PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: pgindent excluded files list
Date: 2010-04-01 01:31:39
Message-ID: 201004010131.o311Vdd19017@momjian.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Andrew Dunstan wrote:
>
> I propose that we create a file containing the list of patterns to
> exclude from pgindent runs. It would look like this:
>
> #list of file patterns to exclude from pg_indent runs
> /s_lock\.h$
> /ecpg/test/expected/
> /snowball/libstemmer/
> /ecpg/include/(sqlda|sqltypes)\.h$
> /ecpg/include/preproc/struct\.h$
> /pl/plperl/ppport\.h$
>
>
> Then a pgindent run would look like this:
>
> find . -name '*.[ch]' -type f -print | \
> egrep -v -f src/tools/pgindent/exclude_files | \
> xargs -n100 pgindent src/tools/pgindent/typedefs.list
>
>
> which is shorter and more efficient and less error prone than the way it's done in the current instructions (which puts the patterns to be excluded in a series of egrep pipes).

Great, just update the pgindent README.

--
Bruce Momjian <bruce(at)momjian(dot)us> http://momjian.us
EnterpriseDB http://enterprisedb.com

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Bruce Momjian 2010-04-01 01:43:37 Re: sorry, too many standbys already vs. MaxWalSenders vs. max_wal_senders
Previous Message Robert Haas 2010-04-01 01:19:38 Re: Parameter name standby_mode