Skip site navigation (1) Skip section navigation (2)

Re: Order of pg_stat_activity timestamp columns

From: Bruce Momjian <bruce(at)momjian(dot)us>
To: Magnus Hagander <magnus(at)hagander(dot)net>
Cc: PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Order of pg_stat_activity timestamp columns
Date: 2010-03-17 21:05:06
Message-ID: 201003172105.o2HL56G26888@momjian.us (view raw or flat)
Thread:
Lists: pgsql-hackers
Magnus Hagander wrote:
> On Wed, Mar 17, 2010 at 21:42, Bruce Momjian <bruce(at)momjian(dot)us> wrote:
> > Has anyone ever noticed that the order of pg_stat_activity timestamp
> > columns is illogical:
> >
> > ?xact_start ? ? ? | timestamp with time zone |
> > ?query_start ? ? ?| timestamp with time zone |
> > ?backend_start ? ?| timestamp with time zone |
> 
> Well, 7.4 had only "query start". 8.1 added backend. 8.3 added
> transaction. So I guess my original guess that things were just added
> on the end was wrong :-)
> 
> 
> > query_start is always between the other two timestamps. ?Moving
> > query_start before xact_start would make the most sense. ?I wouldn't
> > bring this up except we just added application_name before these
> > columns, so we are already going to have different column locations for
> > these fields in 9.0.
> >
> > Should we move query_start?
> 
> Or perhaps we should consider moving application_name to the end so it
> *doesn't* break them?

That's a possibility, but we obviously have been adding columns
out-of-order for several releases now and no one has complained.

-- 
  Bruce Momjian  <bruce(at)momjian(dot)us>        http://momjian.us
  EnterpriseDB                             http://enterprisedb.com

  PG East:  http://www.enterprisedb.com/community/nav-pg-east-2010.do

In response to

Responses

pgsql-hackers by date

Next:From: Jeff DavisDate: 2010-03-17 21:09:48
Subject: Re: An idle thought
Previous:From: Simon RiggsDate: 2010-03-17 21:04:27
Subject: Re: Standalone backends run StartupXLOG in an incorrect environment

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group