Skip site navigation (1) Skip section navigation (2)

Re: [GENERAL] trouble with to_char('L')

From: Bruce Momjian <bruce(at)momjian(dot)us>
To: Takahiro Itagaki <itagaki(dot)takahiro(at)oss(dot)ntt(dot)co(dot)jp>
Cc: Hiroshi Inoue <inoue(at)tpf(dot)co(dot)jp>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: [GENERAL] trouble with to_char('L')
Date: 2010-03-12 17:13:48
Message-ID: 201003121713.o2CHDm828424@momjian.us (view raw or flat)
Thread:
Lists: pgsql-generalpgsql-hackers
Takahiro Itagaki wrote:
> 
> Bruce Momjian <bruce(at)momjian(dot)us> wrote:
> 
> > OK, I have created a new function, win32_wchar_to_db_encoding(), to
> > share the conversion from wide characters to the database encoding.
> > New patch attached.
> 
> Since 9.0 has GetPlatformEncoding() for the purpose, we could simplify
> db_encoding_strdup() with the function. Like this:
> 
> static char *
> db_encoding_strdup(const char *str)
> {
> 	char   *pstr;
> 	char   *mstr;
> 
> 	/* convert the string to the database encoding */
> 	pstr = (char *) pg_do_encoding_conversion(
> 						(unsigned char *) str, strlen(str),
> 						GetPlatformEncoding(), GetDatabaseEncoding());
> 	mstr = strdup(pstr);
> 	if (pstr != str)
> 		pfree(pstr);
> 
> 	return mstr;
> }
> 
> I beleive the code is harmless on all platforms and we can use it
> instead of strdup() without any #ifdef WIN32 quotes.

OK, I don't have any Win32 people testing this patch so if we want this
fixed for 9.0 someone is going to have to test my patch to see that it
works.  Can you make the adjustments suggested above to my patch and
test it to see that it works so we can apply it for 9.0?

> BTW, I found we'd better to add "ANSI_X3.4-1968" as an alias for
> PG_SQL_ASCII. My Fedora 12 returns the name when --no-locale is used.

OK.

-- 
  Bruce Momjian  <bruce(at)momjian(dot)us>        http://momjian.us
  EnterpriseDB                             http://enterprisedb.com

  PG East:  http://www.enterprisedb.com/community/nav-pg-east-2010.do

In response to

Responses

pgsql-hackers by date

Next:From: Tom LaneDate: 2010-03-12 17:45:43
Subject: Re: Reposnse from backend when wrong user/database request send
Previous:From: David FetterDate: 2010-03-12 16:54:56
Subject: Re: Dyamic updates of NEW with pl/pgsql

pgsql-general by date

Next:From: Domenico RotirotiDate: 2010-03-12 17:15:59
Subject: [RFC] Comments on PostPic project
Previous:From: Scott BaileyDate: 2010-03-12 17:07:43
Subject: Re: Function with DEFAULT arguments

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group