Skip site navigation (1) Skip section navigation (2)

Re: Re: incorrect exit code from psql with single transaction + violation of deferred FK constraint

From: Bruce Momjian <bruce(at)momjian(dot)us>
To: Bruce Momjian <bruce(at)momjian(dot)us>
Cc: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Dominic Bevacqua <dominic(dot)bevacqua(at)bpmlogic(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Re: incorrect exit code from psql with single transaction + violation of deferred FK constraint
Date: 2010-03-08 23:03:11
Message-ID: 201003082303.o28N3Bq09198@momjian.us (view raw or flat)
Thread:
Lists: pgsql-bugspgsql-hackers
Bruce Momjian wrote:
> BBruce Momjian wrote:
> > Tom Lane wrote:
> > > Bruce Momjian <bruce(at)momjian(dot)us> writes:
> > > > The attached patch checks for the proper return from BEGIN/COMMIT, and
> > > > properly frees the libpq structures.  In testing, this does return 3 as
> > > > you expected.
> > > 
> > > Really?  It looks to me like you'd get exit(1).  Maybe that's the right
> > > thing, but MainLoop itself seems to return EXIT_USER not EXIT_FAILURE
> > > when it gets an error.
> > 
> > Sorry, you are right.  I must have mis-read my tests.  Updated patch
> > attached.
> 
> I thought some more about it and realized I had to check for the
> on-error-exit flag too. Updated patch attached.

Applied.

-- 
  Bruce Momjian  <bruce(at)momjian(dot)us>        http://momjian.us
  EnterpriseDB                             http://enterprisedb.com

  PG East:  http://www.enterprisedb.com/community/nav-pg-east-2010.do

In response to

Responses

pgsql-hackers by date

Next:From: Tom LaneDate: 2010-03-09 00:09:26
Subject: Re: Re: incorrect exit code from psql with single transaction + violation of deferred FK constraint
Previous:From: Bruce MomjianDate: 2010-03-08 22:57:20
Subject: Re: disabling log_min_duration_statement from pg_dump?

pgsql-bugs by date

Next:From: Tom LaneDate: 2010-03-09 00:09:26
Subject: Re: Re: incorrect exit code from psql with single transaction + violation of deferred FK constraint
Previous:From: SavitaDate: 2010-03-08 10:19:26
Subject: BUG #5365: pg_ctl start gives error

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group