Skip site navigation (1) Skip section navigation (2)

pgsql: When reading pg_hba.conf and similar files, do not treat @file as

From: tgl(at)postgresql(dot)org (Tom Lane)
To: pgsql-committers(at)postgresql(dot)org
Subject: pgsql: When reading pg_hba.conf and similar files, do not treat @file as
Date: 2010-03-06 00:46:02
Message-ID: 20100306004602.1EE277541D1@cvs.postgresql.org (view raw or flat)
Thread:
Lists: pgsql-committers
Log Message:
-----------
When reading pg_hba.conf and similar files, do not treat @file as an inclusion
unless (1) the @ isn't quoted and (2) the filename isn't empty.  This guards
against unexpectedly treating usernames or other strings in "flat files"
as inclusion requests, as seen in a recent trouble report from Ed L.
The empty-filename case would be guaranteed to misbehave anyway, because our
subsequent path-munging behavior results in trying to read the directory
containing the current input file.

I think this might finally explain the report at
http://archives.postgresql.org/pgsql-bugs/2004-05/msg00132.php
of a crash after printing "authentication file token too long, skipping",
since I was able to duplicate that message (though not a crash) on a
platform where stdio doesn't refuse to read directories.  We never got
far in investigating that problem, but now I'm suspicious that the trigger
condition was an @ in the flat password file.

Back-patch to all active branches since the problem can be demonstrated in all
branches except HEAD.  The test case, creating a user named "@", doesn't cause
a problem in HEAD since we got rid of the flat password file.  Nonetheless it
seems like a good idea to not consider quoted @ as a file inclusion spec,
so I changed HEAD too.

Tags:
----
REL8_3_STABLE

Modified Files:
--------------
    pgsql/src/backend/libpq:
        hba.c (r1.164.2.1 -> r1.164.2.2)
        (http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/backend/libpq/hba.c?r1=1.164.2.1&r2=1.164.2.2)

pgsql-committers by date

Next:From: Tom LaneDate: 2010-03-06 00:46:08
Subject: pgsql: When reading pg_hba.conf and similar files, do not treat @file as
Previous:From: Tom LaneDate: 2010-03-06 00:45:55
Subject: pgsql: When reading pg_hba.conf and similar files, do not treat @file as

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group