Re: Could we do pgindent on just utils/adt/xml.c in the 8.3 branch?

From: Bruce Momjian <bruce(at)momjian(dot)us>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: pgsql-hackers(at)postgreSQL(dot)org
Subject: Re: Could we do pgindent on just utils/adt/xml.c in the 8.3 branch?
Date: 2010-03-03 00:33:30
Message-ID: 201003030033.o230XUi19080@momjian.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Tom Lane wrote:
> Bruce Momjian <bruce(at)momjian(dot)us> writes:
> > Sure, I can easily do that, but I am not sure how to generate a typedef
> > list for that release, except to use the old typedef collection method
> > for that file. Is that OK?
>
> One of the things I noticed while patching was that the 8.3 typedef list
> was missing xmlChar and a few other typedefs that are used a lot in that
> file :-(. So please don't use the same method you used in 8.3.

Yes, I don't have libxml installed on this machine so it didn't pick up
those typedefs.

> I think it would be close enough to use the current (just added to CVS)
> typedef list. Or use the one you used for 8.4 if you have it handy.
> There is not a lot of difference between the 8.3 and current code in
> that file, so either of those are probably going to give you the same
> results.

Done. Sorry for the delay.

--
Bruce Momjian <bruce(at)momjian(dot)us> http://momjian.us
EnterpriseDB http://enterprisedb.com

PG East: http://www.enterprisedb.com/community/nav-pg-east-2010.do

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Andrew Dunstan 2010-03-03 00:33:47 plperl _init settings
Previous Message Andrew Dunstan 2010-03-03 00:23:39 Re: USE_LIBXSLT in MSVC builds