Skip site navigation (1) Skip section navigation (2)

Re: [GENERAL] trouble with to_char('L')

From: Bruce Momjian <bruce(at)momjian(dot)us>
To: Hiroshi Inoue <inoue(at)tpf(dot)co(dot)jp>
Cc: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Alvaro Herrera <alvherre(at)commandprompt(dot)com>, Mikko <mhannesy(at)gmail(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgreSQL(dot)org>
Subject: Re: [GENERAL] trouble with to_char('L')
Date: 2010-02-28 04:28:12
Message-ID: 201002280428.o1S4SCb29156@momjian.us (view raw or flat)
Thread:
Lists: pgsql-generalpgsql-hackers
Hiroshi Inoue wrote:
> Bruce Momjian wrote:
> > Hiroshi Inoue wrote:
> >> Bruce Momjian wrote:
> >>> Where are we on this issue?
> >> Oops I forgot it completely.
> >> I have a little improved version and would post it tonight.
> > 
> > Ah, very good.  Thanks.
> 
> Attached is an improved version.

I spent many hours on this patch and am attaching an updated version.
I have restructured the code and added many comments, but this is the
main one:

	*  Ideally, the server encoding and locale settings would
	*  always match.  Unfortunately, WIN32 does not support UTF-8
	*  values for setlocale(), even though PostgreSQL runs fine with
	*  a UTF-8 encoding on Windows:
	*
	*      http://msdn.microsoft.com/en-us/library/x99tb11d.aspx
	*
	*  Therefore, we must set LC_CTYPE to match LC_NUMERIC and
	*  LC_MONETARY, call localeconv(), and use mbstowcs() to
	*  convert the locale-aware string, e.g. Euro symbol, which
	*  is not in UTF-8 to the server encoding.

I need someone with WIN32 experience to review and test this patch.

-- 
  Bruce Momjian  <bruce(at)momjian(dot)us>        http://momjian.us
  EnterpriseDB                             http://enterprisedb.com

  PG East:  http://www.enterprisedb.com/community/nav-pg-east-2010.do

Attachment: /pgpatches/pg_locale
Description: text/x-diff (8.1 KB)

In response to

Responses

pgsql-hackers by date

Next:From: Greg SmithDate: 2010-02-28 05:28:17
Subject: Re: Hot Standby query cancellation and Streaming Replication integration
Previous:From: Tom LaneDate: 2010-02-28 04:22:00
Subject: Re: Avoiding bad prepared-statement plans.

pgsql-general by date

Next:From: Greg SmithDate: 2010-02-28 05:18:41
Subject: Re: Hung postmaster (8.3.9)
Previous:From: Ed L.Date: 2010-02-28 03:37:04
Subject: Hung postmaster (8.3.9)

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group