Re: pgsql: Document why pgindent wants a fresh CVS checkout.

From: Bruce Momjian <bruce(at)momjian(dot)us>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: pgsql-committers(at)postgresql(dot)org
Subject: Re: pgsql: Document why pgindent wants a fresh CVS checkout.
Date: 2010-02-26 15:43:29
Message-ID: 201002261543.o1QFhTF06965@momjian.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Tom Lane wrote:
> momjian(at)postgresql(dot)org (Bruce Momjian) writes:
> > Log Message:
> > -----------
> > Document why pgindent wants a fresh CVS checkout.
>
> Why not just recommend "make maintainer-clean"?
>
> I think that using a fresh checkout is a good idea to ensure that you
> don't have any other changes in your tree (which would then get
> committed silently and accidentally); but the reason given here is
> pretty bogus.

Ah, yea, I couldn't find that in psql/Makefile last night, but I see it
now. I have updated the README.

> BTW, shouldn't the sequence of steps be first download and then change
> into that directory?

Yea, I removed the CVS download idea now that you showed me
maintainer-clean works.

--
Bruce Momjian <bruce(at)momjian(dot)us> http://momjian.us
EnterpriseDB http://enterprisedb.com
PG East: http://www.enterprisedb.com/community/nav-pg-east-2010.do
+ If your life is a hard drive, Christ can be your backup. +

In response to

Browse pgsql-committers by date

  From Date Subject
Next Message Bruce Momjian 2010-02-26 15:57:34 pgsql: Wording improvements to README.
Previous Message Bruce Momjian 2010-02-26 15:42:37 pgsql: Update pgindent docs to use maintainer-clean.