Re: A thought: should we run pgindent now?

From: Bruce Momjian <bruce(at)momjian(dot)us>
To: Greg Smith <greg(at)2ndquadrant(dot)com>
Cc: Robert Haas <robertmhaas(at)gmail(dot)com>, Andrew Dunstan <andrew(at)dunslane(dot)net>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, pgsql-hackers(at)postgresql(dot)org
Subject: Re: A thought: should we run pgindent now?
Date: 2010-02-26 13:29:41
Message-ID: 201002261329.o1QDTf826478@momjian.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Greg Smith wrote:
> Bruce Momjian wrote:
> > The diff is here:
> >
> > http://momjian.us/tmp/pgindent.diff
> >
> > and I checked into CVS a copy of the typedef list I used from Andrew
> > Dunstan.
> >
>
> Is it worthwhile to consider writing up a "how to run pgindent like
> Bruce does" page on the wiki? I've been scared off of that topic before
> because it always seemed like it was perilous and there were missing
> pieces. I think we'd get some uptake from contributors doing this
> themselves before submitting patches if it were made easy enough for
> them to do. I know I'd do it just to get rid of the accidental
> tab/space errors that always manage to sneak into non-trivial work, if I
> could automate the whole thing as a pass to do just before generating a
> final diff to submit.

Have you read the README in src/tools/pgindent?

--
Bruce Momjian <bruce(at)momjian(dot)us> http://momjian.us
EnterpriseDB http://enterprisedb.com
PG East: http://www.enterprisedb.com/community/nav-pg-east-2010.do
+ If your life is a hard drive, Christ can be your backup. +

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Michael Meskes 2010-02-26 13:46:24 Re: NaN/Inf fix for ECPG
Previous Message Greg Stark 2010-02-26 13:00:08 Re: pg_stop_backup does not complete