Skip site navigation (1) Skip section navigation (2)

Re: Path separator

From: Bruce Momjian <bruce(at)momjian(dot)us>
To: Magnus Hagander <magnus(at)hagander(dot)net>
Cc: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, PG Hackers <pgsql-hackers(at)postgresql(dot)org>, Dave Page <dpage(at)pgadmin(dot)org>
Subject: Re: Path separator
Date: 2010-02-26 04:18:51
Message-ID: 201002260418.o1Q4Ipr27552@momjian.us (view raw or flat)
Thread:
Lists: pgsql-hackers
I assume we never came to any conclusion on this.

---------------------------------------------------------------------------

Magnus Hagander wrote:
> Tom Lane wrote:
> > Magnus Hagander <magnus(at)hagander(dot)net> writes:
> >>> Answering myself here: the filesize for the "frontend only" part is
> >>> about 2k on this system.
> > 
> >> Long meeting, time for coding.. :-) Here's a rough patch. Is this about
> >> what you had in mind?
> > 
> > Hm, this seems to make the namespace pollution problem worse not better,
> > because of de-staticizing so many functions.  I guess we could stick pg_
> > prefixes on all of them.  That's a bit ugly; anybody have a better idea?
> 
> Not really.
> 
> 
> > It might be that it'd be better to push a couple more of the simple
> > path-munging functions (like join_path_components) over into the new
> > file, so as to have a more logical division of responsibilities.
> > In my mind the two key areas here are "path syntax knowledge" and
> > "extracting absolute paths from environmental information".  The second
> > part seems to be the one that doesn't belong on the frontend side.
> 
> What would be the gain there? To be able to re-static-ify for example
> skip_drive? Or just a nicer division?
> 
> We should probably also consider moving get_home_path() over to the
> frontend one, and get rid of the copy that's in fe-connect.c.
> 
> 
> //Magnus
> 
> 
> -- 
> Sent via pgsql-hackers mailing list (pgsql-hackers(at)postgresql(dot)org)
> To make changes to your subscription:
> http://www.postgresql.org/mailpref/pgsql-hackers

-- 
  Bruce Momjian  <bruce(at)momjian(dot)us>        http://momjian.us
  EnterpriseDB                             http://enterprisedb.com
  PG East:  http://www.enterprisedb.com/community/nav-pg-east-2010.do
  + If your life is a hard drive, Christ can be your backup. +

In response to

Responses

pgsql-hackers by date

Next:From: Pavan DeolaseeDate: 2010-02-26 04:19:47
Subject: Re: visibility maps and heap_prune
Previous:From: Bruce MomjianDate: 2010-02-26 04:15:29
Subject: Re: Allow vacuumdb to only analyze

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group