Hi,

I notice that the new plperl error messages are somewhat out of line of
our usual style:

            ereport(ERROR,
                    (errcode(ERRCODE_INTERNAL_ERROR),
                        errmsg("while executing utf8fix"),
                        errdetail("%s", strip_trailing_ws(SvPV_nolen(ERRSV))) ));

I think the errdetail field should really be errmsg, and the errdetail
should be errcontext.

There are several messages like this.

Should this be fixed?

-- 
Alvaro Herrera                                http://www.CommandPrompt.com/
PostgreSQL Replication, Consulting, Custom Development, 24x7 support

Responses

• Re: plperl message style on newly added messages at 2010-02-15 15:10:57 from Robert Haas

pgsql-hackers by date

Next:	From: Robert Haas	Date: 2010-02-15 15:08:10
	Subject: Re: TCP keepalive support for libpq
Previous:	From: Greg Stark	Date: 2010-02-15 14:55:43
	Subject: Re: Explain buffers display units.