From:
Alvaro Herrera <alvherre(at)commandprompt(dot)com>
To:
Robert Haas <robertmhaas(at)gmail(dot)com>
Cc:
Boszormenyi Zoltan <zb(at)cybertec(dot)at>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>,Peter Eisentraut <peter_e(at)gmx(dot)net>,Hans-Juergen Schoenig <hs(at)cybertec(dot)at>,Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com>,PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject:
Re: [PATCH] Provide rowcount for utility SELECTs
Date:
2010-02-11 19:47:26
Message-ID:
20100211194726.GI3145@alvh.no-ip.org (view raw or flat )
Thread:
2009-12-28 09:57:58 from Boszormenyi Zoltan <zb(at)cybertec(dot)at>
2009-12-28 10:08:13 from Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com>
2009-12-28 10:17:22 from Hans-Juergen Schoenig <hs(at)cybertec(dot)at>
2009-12-28 10:20:57 from Boszormenyi Zoltan <zb(at)cybertec(dot)at>
2009-12-28 16:08:19 from Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
2009-12-28 16:14:04 from Peter Eisentraut <peter_e(at)gmx(dot)net>
2009-12-28 16:20:19 from Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
2009-12-28 18:29:01 from Boszormenyi Zoltan <zb(at)cybertec(dot)at>
2009-12-28 20:18:08 from Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
2009-12-29 07:50:49 from Boszormenyi Zoltan <zb(at)cybertec(dot)at>
2009-12-29 13:35:52 from Alvaro Herrera <alvherre(at)commandprompt(dot)com>
2009-12-29 15:24:38 from Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
2010-01-12 14:23:19 from Boszormenyi Zoltan <zb(at)cybertec(dot)at>
2010-02-01 20:42:02 from Robert Haas <robertmhaas(at)gmail(dot)com>
2010-02-02 09:03:21 from Boszormenyi Zoltan <zb(at)cybertec(dot)at>
2010-02-07 05:01:08 from Robert Haas <robertmhaas(at)gmail(dot)com>
2010-02-07 17:46:18 from Boszormenyi Zoltan <zb(at)cybertec(dot)at>
2010-02-08 04:17:53 from Robert Haas <robertmhaas(at)gmail(dot)com>
2010-02-08 10:53:34 from Boszormenyi Zoltan <zb(at)cybertec(dot)at>
2010-02-11 18:52:12 from Robert Haas <robertmhaas(at)gmail(dot)com>
2010-02-12 15:48:32 from Boszormenyi Zoltan <zb(at)cybertec(dot)at>
2010-02-12 17:34:21 from Robert Haas <robertmhaas(at)gmail(dot)com>
2010-02-12 18:22:06 from Boszormenyi Zoltan <zb(at)cybertec(dot)at>
2010-02-12 18:38:11 from Robert Haas <robertmhaas(at)gmail(dot)com>
2010-02-12 18:55:36 from Boszormenyi Zoltan <zb(at)cybertec(dot)at>
2010-02-12 20:06:16 from Robert Haas <robertmhaas(at)gmail(dot)com>
2010-02-14 03:15:26 from Bruce Momjian <bruce(at)momjian(dot)us>
2010-02-14 03:30:24 from Robert Haas <robertmhaas(at)gmail(dot)com>
2010-02-16 20:58:23 from Bruce Momjian <bruce(at)momjian(dot)us>
2010-02-12 18:29:08 from Boszormenyi Zoltan <zb(at)cybertec(dot)at>
2010-02-11 19:04:08 from Alvaro Herrera <alvherre(at)commandprompt(dot)com>
2010-02-11 19:25:48 from Robert Haas <robertmhaas(at)gmail(dot)com>
2010-02-11 19:38:53 from Alvaro Herrera <alvherre(at)commandprompt(dot)com>
2010-02-11 19:42:49 from Robert Haas <robertmhaas(at)gmail(dot)com>
2010-02-11 19:47:26 from Alvaro Herrera <alvherre(at)commandprompt(dot)com>
2010-02-11 19:50:42 from Robert Haas <robertmhaas(at)gmail(dot)com>
2010-02-11 20:09:06 from Boszormenyi Zoltan <zb(at)cybertec(dot)at>
2010-02-11 20:00:56 from Boszormenyi Zoltan <zb(at)cybertec(dot)at>
2009-12-28 17:10:29 from Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
2009-12-29 07:58:14 from Boszormenyi Zoltan <zb(at)cybertec(dot)at>
2009-12-29 08:06:21 from Robert Haas <robertmhaas(at)gmail(dot)com>
Lists:
pgsql-hackers
Robert Haas escribió:
> On Thu, Feb 11, 2010 at 2:38 PM, Alvaro Herrera
> <alvherre(at)commandprompt(dot)com> wrote:
> > Robert Haas escribió:
> >
> >> I was all prepared to admit that I hadn't actually looked at the patch
> >> carefully enough, but I just looked at (and CVS HEAD) again and what
> >> you've written here doesn't appear to describe what I'm seeing in the
> >> code:
> >>
> >> if ((portal->strategy != PORTAL_ONE_SELECT) && (!portal->holdStore))
> >> FillPortalStore(portal, isTopLevel);
> >>
> >> So one of us is confused... it may well be me.
> >
> > Ah, it seems I misread it ... but then I don't quite see the point in
> > that change.
>
> Well the point is just that Zoltan is adding some more code that
> applies to both branches of the switch, so merging them saves some
> duplication.
But then there's no other branches, so why not just put it below the
switch?
> > Well, not doing a full review anyway, so never mind me.
>
> Actually I was sort of hoping you (or someone other than me) would
> pick this up for commit...
Hmm ...
--
Alvaro Herrera http://www.CommandPrompt.com/
PostgreSQL Replication, Consulting, Custom Development, 24x7 support
In response to
Responses
pgsql-hackers by date
Next :From: Robert HaasDate: 2010-02-11 19:50:42Subject : Re: [PATCH] Provide rowcount for utility SELECTsPrevious :From : Alvaro HerreraDate : 2010-02-11 19:46:37Subject : Re: Re: [COMMITTERS] pgsql: Remove old-style VACUUM FULL
(which was known for a little while
