Re: unable to fail over to warm standby server

From: Alvaro Herrera <alvherre(at)commandprompt(dot)com>
To: Heikki Linnakangas <heikki(dot)linnakangas(at)enterprisedb(dot)com>
Cc: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Robert Haas <robertmhaas(at)gmail(dot)com>, Mason Hale <mason(at)onespot(dot)com>, Fujii Masao <masao(dot)fujii(at)gmail(dot)com>, pgsql-bugs(at)postgresql(dot)org, Simon Riggs <simon(at)2ndquadrant(dot)com>
Subject: Re: unable to fail over to warm standby server
Date: 2010-02-09 22:09:01
Message-ID: 20100209220901.GI5522@alvh.no-ip.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-bugs

Heikki Linnakangas escribió:

> Here's what I came up with. Translatability indeed makes it pretty hard,
> I ended up copy-pasting.

Looks sane to me too; msgmerge segfaults though so I couldn't test. Two
minor comments:

> + /*------
> + translator: %s is a noun phrase describing a child process, such as
> + "restore_command" */
> + errdetail("%s was terminated by signal %d: %s",

You probably want "the first %s is ... and the second %s is the signal
name".

And here:

> + sys_siglist[WTERMSIG(exitstatus)] : "(unknown)");

Should probably be _("(unknown)")

--
Alvaro Herrera http://www.CommandPrompt.com/
PostgreSQL Replication, Consulting, Custom Development, 24x7 support

In response to

Browse pgsql-bugs by date

  From Date Subject
Next Message Fujii Masao 2010-02-10 00:30:32 Re: unable to fail over to warm standby server
Previous Message Tom Lane 2010-02-09 21:59:32 Re: unable to fail over to warm standby server