Skip site navigation (1) Skip section navigation (2)

Re: pgsql: Add C comments that HEAP_MOVED_* define usage is only for pre-9.0

From: Bruce Momjian <bruce(at)momjian(dot)us>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, pgsql-committers(at)postgresql(dot)org
Cc: pgsql-committers(at)postgresql(dot)org
Subject: Re: pgsql: Add C comments that HEAP_MOVED_* define usage is only for pre-9.0
Date: 2010-02-08 17:14:08
Message-ID: 201002081714.o18HE9r04830@momjian.us (view raw or flat)
Thread:
Lists: pgsql-committers
bruce wrote:
> Tom Lane wrote:
> > momjian(at)postgresql(dot)org (Bruce Momjian) writes:
> > > Log Message:
> > > -----------
> > > Add C comments that HEAP_MOVED_* define usage is only for pre-9.0 binary
> > > upgrades.
> > 
> > This seems fairly redundant with the comments that were already there.
> 
> The comment was at the top of SetHintBits(), which I didn't think would
> be seen near the many other references to HEAP_MOVED_* father down
> in the file.

The only other thing we could do is to mention the HEAP_MOVED_* only at
the top of the file, but I have tried to label binary upgrade code
clearly so we know why it is there and when it can be removed.

-- 
  Bruce Momjian  <bruce(at)momjian(dot)us>        http://momjian.us
  EnterpriseDB                             http://enterprisedb.com

  + If your life is a hard drive, Christ can be your backup. +

pgsql-committers by date

Next:From: Heikki LinnakangasDate: 2010-02-08 19:59:49
Subject: pgsql: Remove obsolete comment about 'fsm' argument, which isn't an
Previous:From: Tom LaneDate: 2010-02-08 16:50:21
Subject: pgsql: Fix serious performance bug in new implementation of VACUUM FULL:

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group