> Tom Lane wrote:
> > momjian(at)postgresql(dot)org (Bruce Momjian) writes:
> > > Log Message:
> > > -----------
> > > Add C comments that HEAP_MOVED_* define usage is only for pre-9.0 binary
> > > upgrades.
> > This seems fairly redundant with the comments that were already there.
> The comment was at the top of SetHintBits(), which I didn't think would
> be seen near the many other references to HEAP_MOVED_* father down
> in the file.
The only other thing we could do is to mention the HEAP_MOVED_* only at
the top of the file, but I have tried to label binary upgrade code
clearly so we know why it is there and when it can be removed.
Bruce Momjian <bruce(at)momjian(dot)us> http://momjian.us
+ If your life is a hard drive, Christ can be your backup. +
pgsql-committers by date
|Next:||From: Heikki Linnakangas||Date: 2010-02-08 19:59:49|
|Subject: pgsql: Remove obsolete comment about 'fsm' argument, which isn't an |
|Previous:||From: Tom Lane||Date: 2010-02-08 16:50:21|
|Subject: pgsql: Fix serious performance bug in new implementation of VACUUM FULL: |