Skip site navigation (1) Skip section navigation (2)

Re: [COMMITTERS] pgsql: Remove tabs in SGML.

From: Bruce Momjian <bruce(at)momjian(dot)us>
To: Alvaro Herrera <alvherre(at)commandprompt(dot)com>
Cc: Peter Eisentraut <peter_e(at)gmx(dot)net>, David Fetter <david(at)fetter(dot)org>, PG Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: [COMMITTERS] pgsql: Remove tabs in SGML.
Date: 2010-02-05 19:32:13
Message-ID: 201002051932.o15JWDw04656@momjian.us (view raw or flat)
Thread:
Lists: pgsql-committerspgsql-hackers
Alvaro Herrera wrote:
> Bruce Momjian wrote:
> > Alvaro Herrera wrote:
> 
> > > Maybe have the check-tabs rule as a dependency of the "check", "html"
> > > and/or "draft" rules?
> > > 
> > > > + check-tabs:
> > > > + 	( ! grep '	' $(wildcard $(srcdir)/*.sgml $(srcdir)/ref/*.sgml) ) || (echo "Tabs appear in SGML files";  exit 1)
> > 
> > Uh, I didn't think people wanted to actually have any tab testing in
> > their automatically.  Do they?
> 
> IMO that's the point of the whole exercise.

OK, done with attached patch, now done as part of 'gmake check'.  If
people want it as part of the build process, please let me know.

-- 
  Bruce Momjian  <bruce(at)momjian(dot)us>        http://momjian.us
  EnterpriseDB                             http://enterprisedb.com

  + If your life is a hard drive, Christ can be your backup. +

Attachment: /rtmp/diff
Description: text/x-diff (1.0 KB)

In response to

pgsql-hackers by date

Next:From: James William PyeDate: 2010-02-05 19:54:39
Subject: Re: Confusion over Python drivers
Previous:From: Jeff DavisDate: 2010-02-05 19:32:10
Subject: Re: Confusion over Python drivers

pgsql-committers by date

Next:From: Bruce MomjianDate: 2010-02-05 19:34:57
Subject: pgsql: Properly document that OVER and WINDOW are Postgres reserved
Previous:From: Bruce MomjianDate: 2010-02-05 19:31:18
Subject: pgsql: Previous commit was to have tab checking as part of gmake check.

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group