Skip site navigation (1) Skip section navigation (2)

Re: [COMMITTERS] pgsql: Remove tabs in SGML.

From: David Fetter <david(at)fetter(dot)org>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Peter Eisentraut <peter_e(at)gmx(dot)net>,Bruce Momjian <momjian(at)postgresql(dot)org>,PG Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: [COMMITTERS] pgsql: Remove tabs in SGML.
Date: 2010-01-27 17:30:03
Message-ID: 20100127173003.GW31281@fetter.org (view raw or flat)
Thread:
Lists: pgsql-committerspgsql-hackers
On Wed, Jan 27, 2010 at 12:27:08PM -0500, Tom Lane wrote:
> David Fetter <david(at)fetter(dot)org> writes:
> > On Wed, Jan 27, 2010 at 04:52:00PM +0200, Peter Eisentraut wrote:
> >> Better write a check in the makefile.
> 
> > That assumes that everyone will always actually run the
> > appropriate make before committing, which I wouldn't assume,
> > especially for a "trivial" patch that's going out when someone is
> > pressed for time.  Checking in an unavoidable place seems much
> > more foolproof.
> 
> The rule against tabs in SGML files is only a bit of anal
> retentivity anyway.  I don't think that enforcing it is worth
> special hacks that we do not use anywhere else.

Good point.  What other pre-commit hooks do we need?

Cheers,
David.
-- 
David Fetter <david(at)fetter(dot)org> http://fetter.org/
Phone: +1 415 235 3778  AIM: dfetter666  Yahoo!: dfetter
Skype: davidfetter      XMPP: david(dot)fetter(at)gmail(dot)com
iCal: webcal://www.tripit.com/feed/ical/people/david74/tripit.ics

Remember to vote!
Consider donating to Postgres: http://www.postgresql.org/about/donate

In response to

Responses

pgsql-hackers by date

Next:From: Joshua D. DrakeDate: 2010-01-27 17:33:31
Subject: Re: [COMMITTERS] pgsql: Remove tabs in SGML.
Previous:From: Tom LaneDate: 2010-01-27 17:27:08
Subject: Re: [COMMITTERS] pgsql: Remove tabs in SGML.

pgsql-committers by date

Next:From: Joshua D. DrakeDate: 2010-01-27 17:33:31
Subject: Re: [COMMITTERS] pgsql: Remove tabs in SGML.
Previous:From: Tom LaneDate: 2010-01-27 17:27:08
Subject: Re: [COMMITTERS] pgsql: Remove tabs in SGML.

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group