Skip site navigation (1) Skip section navigation (2)

Re: [COMMITTERS] pgsql: Remove tabs in SGML.

From: David Fetter <david(at)fetter(dot)org>
To: Peter Eisentraut <peter_e(at)gmx(dot)net>
Cc: Bruce Momjian <momjian(at)postgresql(dot)org>,PG Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: [COMMITTERS] pgsql: Remove tabs in SGML.
Date: 2010-01-27 17:04:06
Message-ID: 20100127170406.GV31281@fetter.org (view raw or flat)
Thread:
Lists: pgsql-committerspgsql-hackers
On Wed, Jan 27, 2010 at 04:52:00PM +0200, Peter Eisentraut wrote:
> On tis, 2010-01-26 at 10:20 -0800, David Fetter wrote:
> > On Tue, Jan 26, 2010 at 02:21:29PM +0000, Bruce Momjian wrote:
> > > Log Message:
> > > -----------
> > > Remove tabs in SGML.
> > 
> > Can we see about making a commit hook for CVS that disallows \t in
> > SGML files?  The process in git is pretty simple.
> 
> Better write a check in the makefile.

That assumes that everyone will always actually run the appropriate
make before committing, which I wouldn't assume, especially for a
"trivial" patch that's going out when someone is pressed for time.
Checking in an unavoidable place seems much more foolproof.

Cheers,
David.
-- 
David Fetter <david(at)fetter(dot)org> http://fetter.org/
Phone: +1 415 235 3778  AIM: dfetter666  Yahoo!: dfetter
Skype: davidfetter      XMPP: david(dot)fetter(at)gmail(dot)com
iCal: webcal://www.tripit.com/feed/ical/people/david74/tripit.ics

Remember to vote!
Consider donating to Postgres: http://www.postgresql.org/about/donate

In response to

Responses

pgsql-hackers by date

Next:From: Tom LaneDate: 2010-01-27 17:08:48
Subject: Re: Add on_perl_init and proper destruction to plperl [PATCH]
Previous:From: Tom LaneDate: 2010-01-27 17:01:54
Subject: Re: Add on_perl_init and proper destruction to plperl [PATCH]

pgsql-committers by date

Next:From: Tom LaneDate: 2010-01-27 17:27:08
Subject: Re: [COMMITTERS] pgsql: Remove tabs in SGML.
Previous:From: Heikki LinnakangasDate: 2010-01-27 16:41:09
Subject: pgsql: Fix bug in wasender's xlogid boundary handling, reported by Erik

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group