Re: An example of bugs for Hot Standby

Hi Tom, Hi Simon,

On Wednesday 20 January 2010 17:59:36 Tom Lane wrote:
> Andres Freund <andres(at)anarazel(dot)de> writes:
> > I realize its way too late in the cycle for that, but why dont we start
> > using some library for easy cross platform atomic ops?
>
> (1) there probably isn't one that does exactly what we want, works
> everywhere, and has the right license;
> (2) what actual gain would we get? We've already done the work.
That there might be some other instructions were interested in?
Like really atomic increment?

> >> [ grows visibly pale ] *Please* tell me we are not trying to take
> >> locks in a signal handler. What happens if it interrupts code that
> >> is already holding that lock?
> >
> > Yes the patch does that at two places.
>
> That's a must-fix.
Its code intended to fix a existing problem not already comitted code. But
otherwise I definitely agree.

Andres