Skip site navigation (1) Skip section navigation (2)

Re: plpgsql: open for execute - add USING clause

From: Takahiro Itagaki <itagaki(dot)takahiro(at)oss(dot)ntt(dot)co(dot)jp>
To: Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com>
Cc: PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: plpgsql: open for execute - add USING clause
Date: 2010-01-12 09:38:00
Message-ID: 20100112183800.C52D.52131E4D@oss.ntt.co.jp (view raw or flat)
Thread:
Lists: pgsql-hackers
Hi, I'm reviewing OPEN FOR EXECUTE USING patch and have a couple of
trivial comments.

Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com> wrote:

> this small patch add missing USING clause to OPEN FOR EXECUTE statement
> + cleaning part of exec_stmt_open function

- Can we use read_sql_expression2() instead of read_sql_construct()
  in gram.y? It could simplify the code a bit.

- I'd prefer to change the new argument for exec_dynquery_with_params()
  from "char *portalname" to "const char *curname". 

Other than the above minor issues, this patch is ready to commit.

Regards,
---
Takahiro Itagaki
NTT Open Source Software Center



In response to

Responses

pgsql-hackers by date

Next:From: Takahiro ItagakiDate: 2010-01-12 10:10:09
Subject: Re: NOT NULL violation and error-message
Previous:From: Pavel StehuleDate: 2010-01-12 09:34:54
Subject: Re: Typed tables

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group