Skip site navigation (1) Skip section navigation (2)

Re: pgsql: PG_MAJORVERSION: For simplicity, use PG_MAJORVERSION rather than

From: Alvaro Herrera <alvherre(at)commandprompt(dot)com>
To: Bruce Momjian <bruce(at)momjian(dot)us>
Cc: pgsql-committers(at)postgresql(dot)org
Subject: Re: pgsql: PG_MAJORVERSION: For simplicity, use PG_MAJORVERSION rather than
Date: 2010-01-07 03:18:51
Message-ID: 20100107031851.GZ6129@alvh.no-ip.org (view raw or flat)
Thread:
Lists: pgsql-committers
Bruce Momjian wrote:
> Alvaro Herrera wrote:

> > I think this is a bad style to use for commit messages.  For GIT, a good
> > commit message is a first line being a summary, and a more extensive
> > message below.
> 
> That is just too odd. I think I forgot about the summary idea then.

What is odd?

If I was unclear, look at this status page:

http://git.postgresql.org/gitweb?p=postgresql.git;a=shortlog

Note that for your commit it only says "PG_MAJORVERSION:".  You have to
open the patch's page to see the rest of the message.

-- 
Alvaro Herrera                                http://www.CommandPrompt.com/
PostgreSQL Replication, Consulting, Custom Development, 24x7 support

In response to

Responses

pgsql-committers by date

Next:From: Tom LaneDate: 2010-01-07 03:24:57
Subject: pgsql: Fail in a nicer way if we have --with-perl and no Perl.
Previous:From: Tom LaneDate: 2010-01-07 03:13:44
Subject: Re: [COMMITTERS] pgsql: Support ALTER TABLESPACE name SET/RESET ( tablespace_options ).

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group