Re: pgsql: PG_MAJORVERSION: For simplicity, use PG_MAJORVERSION rather than

Alvaro Herrera wrote:
> Bruce Momjian wrote:
> > Log Message:
> > -----------
> > PG_MAJORVERSION:
> >
> > For simplicity, use PG_MAJORVERSION rather than PG_VERSION for creation
> > of the PG_VERSION file.
>
> I think this is a bad style to use for commit messages. For GIT, a good
> commit message is a first line being a summary, and a more extensive
> message below. The way you used a contentless first line means that
> somebody perusing a "git shortlog" or "git annotate" does not get any
> useful information out of it. It would have been better phrased
> like
>
> "Use PG_MAJORVERSION define to create the PG_VERSION file
>
> It is easier than using the PG_VERSION define."
>
> or similar.

That is just too odd. I think I forgot about the summary idea then.

--
Bruce Momjian <bruce(at)momjian(dot)us> http://momjian.us
EnterpriseDB http://enterprisedb.com

+ If your life is a hard drive, Christ can be your backup. +