Bruce Momjian wrote:
> Log Message:
> For simplicity, use PG_MAJORVERSION rather than PG_VERSION for creation
> of the PG_VERSION file.
I think this is a bad style to use for commit messages. For GIT, a good
commit message is a first line being a summary, and a more extensive
message below. The way you used a contentless first line means that
somebody perusing a "git shortlog" or "git annotate" does not get any
useful information out of it. It would have been better phrased
"Use PG_MAJORVERSION define to create the PG_VERSION file
It is easier than using the PG_VERSION define."
It is also bad for pgsql-committers list archives, because those get an
extract of the first line too.
Alvaro Herrera http://www.CommandPrompt.com/
PostgreSQL Replication, Consulting, Custom Development, 24x7 support
In response to
pgsql-committers by date
|Next:||From: Bruce Momjian||Date: 2010-01-07 00:09:24|
|Subject: Re: pgsql: PG_MAJORVERSION: For simplicity, use
PG_MAJORVERSION rather than|
|Previous:||From: Bruce Momjian||Date: 2010-01-06 23:23:51|
|Subject: pgsql: PG_MAJORVERSION: For simplicity, use PG_MAJORVERSION rather than |