| From: | Alvaro Herrera <alvherre(at)commandprompt(dot)com> |
|---|---|
| To: | Robert Haas <robertmhaas(at)gmail(dot)com> |
| Cc: | Jaime Casanova <jcasanov(at)systemguards(dot)com(dot)ec>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Greg Stark <gsstark(at)mit(dot)edu>, pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: patch - per-tablespace random_page_cost/seq_page_cost |
| Date: | 2010-01-04 15:42:32 |
| Message-ID: | 20100104154232.GG3778@alvh.no-ip.org |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Robert Haas escribió:
> Hmm, I see this needs to be rebased over Tom's latest changes, but the
> conflict I got was in syscache.h, rather than syscache.c. Not sure if
> that's what you were going for or if there's another issue. Updated
> patch attached.
FWIW I think the reloptions code in this patch is sane enough. The fact
that it was this easily written means that the API for reloptions was
reasonably chosen, thanks :-)
Hmm, it seems we're missing a "need_initialization = false" at the
bottom of initialize_reloptions ... I'm wondering what happened to
that??
--
Alvaro Herrera http://www.CommandPrompt.com/
PostgreSQL Replication, Consulting, Custom Development, 24x7 support
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Alvaro Herrera | 2010-01-04 15:45:41 | Re: Setting oom_adj on linux? |
| Previous Message | Magnus Hagander | 2010-01-04 15:39:14 | Setting oom_adj on linux? |