Tom Lane wrote:
> Magnus Hagander <magnus(at)hagander(dot)net> writes:
> > Attached patch is the part of the win64 patch that changes Datum to be
> > uintptr_t, and associated changes, with only very minor changes from
> > me. It also includes autoconf tests that I tricked Bruce into fixing
> > for me :-)
> > Comments?
> This is a joke no? Where's the logic to provide a definition of
> intptr_t if the platform fails to? The lack of attention to updating
> the comments about Datum doesn't give me a warm feeling either.
> BTW, it looks like the patch is showing a manual change to
> pg_config.h.in. Don't do that. Run autoheader.
I wasn't aware autoheader existed. Is that new or has it alwasy been
part of autoconf?
Attached is the diff for pg_config.h.in generated by autoheader.
Bruce Momjian <bruce(at)momjian(dot)us> http://momjian.us
+ If your life is a hard drive, Christ can be your backup. +
Description: text/x-diff (1.6 KB)
In response to
pgsql-hackers by date
|Next:||From: David E. Wheeler||Date: 2009-12-31 17:47:24|
|Subject: Re: Status of plperl inter-sp calling|
|Previous:||From: Simon Riggs||Date: 2009-12-31 17:40:01|
|Subject: Re: Hot Standy introduced problem with query cancel