Skip site navigation (1) Skip section navigation (2)

Re: uintptr_t for Datum

From: Bruce Momjian <bruce(at)momjian(dot)us>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Magnus Hagander <magnus(at)hagander(dot)net>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: uintptr_t for Datum
Date: 2009-12-31 17:43:44
Message-ID: 200912311743.nBVHhiI11001@momjian.us (view raw or flat)
Thread:
Lists: pgsql-hackers
Tom Lane wrote:
> Magnus Hagander <magnus(at)hagander(dot)net> writes:
> > Attached patch is the part of the win64 patch that changes Datum to be
> > uintptr_t, and associated changes, with only very minor changes from
> > me. It also includes autoconf tests that I tricked Bruce into fixing
> > for me :-)
> 
> > Comments?
> 
> This is a joke no?  Where's the logic to provide a definition of
> intptr_t if the platform fails to?  The lack of attention to updating
> the comments about Datum doesn't give me a warm feeling either.
> 
> BTW, it looks like the patch is showing a manual change to
> pg_config.h.in.  Don't do that.  Run autoheader.

I wasn't aware autoheader existed.  Is that new or has it alwasy been
part of autoconf?

Attached is the diff for pg_config.h.in generated by autoheader.

-- 
  Bruce Momjian  <bruce(at)momjian(dot)us>        http://momjian.us
  EnterpriseDB                             http://enterprisedb.com

  + If your life is a hard drive, Christ can be your backup. +

Attachment: /rtmp/diff
Description: text/x-diff (1.6 KB)

In response to

Responses

pgsql-hackers by date

Next:From: David E. WheelerDate: 2009-12-31 17:47:24
Subject: Re: Status of plperl inter-sp calling
Previous:From: Simon RiggsDate: 2009-12-31 17:40:01
Subject: Re: Hot Standy introduced problem with query cancel behavior

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group